Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature #72 - Manage tokens #84

Merged
merged 27 commits into from
Nov 9, 2018
Merged

Conversation

apanizo
Copy link
Contributor

@apanizo apanizo commented Nov 5, 2018

Description
This PR introduces the logic and UI changes which allow managing tokens on the default safe's view (Balances Tab).
Now we display selected tokens, and we include some features for filtering based on #73 description.

@apanizo
Copy link
Contributor Author

apanizo commented Nov 5, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@tschubotz
Copy link
Member

Looks really smooth!

I just have 2 comments about the token search:

  • Could we enable search by token name as well? i.e. e.g. searching for "Omis" would reveal the OMG token as well?
  • Also, currently it's just a prefix search, right? so a search for "NO" would not return the GNO token. Could we change that to a "contain" search, i.e. the token is returned if the search term is a substring of token symbol or name?

@apanizo
Copy link
Contributor Author

apanizo commented Nov 5, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

1 similar comment
@apanizo
Copy link
Contributor Author

apanizo commented Nov 5, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@apanizo
Copy link
Contributor Author

apanizo commented Nov 5, 2018

Thanks!!!

@tschubotz Changes submitted. Can you check again?

@apanizo
Copy link
Contributor Author

apanizo commented Nov 6, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@apanizo
Copy link
Contributor Author

apanizo commented Nov 6, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@apanizo
Copy link
Contributor Author

apanizo commented Nov 7, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@apanizo
Copy link
Contributor Author

apanizo commented Nov 8, 2018

Travis automatic deployment:
https://pr84--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr84--safereactstorybook.review.gnosisdev.com

@tschubotz
Copy link
Member

👍

@apanizo apanizo changed the base branch from feature/tokens-view to development November 9, 2018 08:58
@apanizo apanizo merged commit 8d9c058 into development Nov 9, 2018
@apanizo apanizo deleted the feature/#72-manage-tokens branch November 9, 2018 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants