Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Safe overview #73

Closed
tschubotz opened this issue Oct 18, 2018 · 2 comments
Closed

Safe overview #73

tschubotz opened this issue Oct 18, 2018 · 2 comments

Comments

@tschubotz
Copy link
Member

tschubotz commented Oct 18, 2018

Story
As a user I am able to see a clear overview of my Safe, in order to receive, see and send funds.

Acceptance criteria
ui v1 1 - 4c safes detail

  • Ether and all enabled token balances are displayed.
    • ETH on top, the others sorted by name ascending.
  • Columns can be sorted. (Then ETH isn't stuck to the top but in the respective place)
  • Clicking the Safe address on top opens Etherscan
  • By hovering over a row, "Receive" and "Send" button are displayed.
  • User can click "Receive" to display the receive modal: Receive funds #71
  • User can click "Send" to start the transaction flow.
  • Clicking "Hide tokens with 0 balance" hides the respective token rows.
  • Please don't include the fiat value column right now.
  • User can specify how many rows are displayed per page.
  • User can click through the different pages
  • Clicking "Transactions" opens the transaction list: Transaction list #79
  • Clicking "Settings" opens the settings: Safe settings: Change Safe name & Remove Safe #76, Safe settings: Change required confirmations #77, Safe settings: Manage owners #78
  • User can "Manage tokens": Manage tokens #72

Read only Safe
ui v1 1 - 4d safes detail readonly

  • In case the current user is not an owner, please show the Safe as readonly, i.e.
    • Send buttons are hidden
    • The "Read only" badge is displayed.

Open via link

  • Opening a Safe via link is possible even if the Safe is not present in the local storage.
    • Safe is read-only if the current wallet is not an owner
  • User sees an error if we cannot decode a Safe at the address of the link.
apanizo added a commit that referenced this issue Oct 30, 2018
apanizo added a commit that referenced this issue Nov 5, 2018
@tschubotz
Copy link
Member Author

Looks good to me!
Concerning User sees an error if we cannot decode a Safe at the address of the link. I think it's cool like it is, we can always add a better error page later. Currently it says "Not found Safe" -> Could you please change that to "Safe not found"? :)
I think then it's cool!

@apanizo
Copy link
Contributor

apanizo commented Nov 5, 2018

Thanks!!

Already solved in https://pr82--safereact.review.gnosisdev.com

Can you check again?

apanizo added a commit that referenced this issue Nov 9, 2018
@apanizo apanizo closed this as completed Nov 9, 2018
@lukasschor lukasschor added this to the Team Edition - MVP milestone May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants