Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Development v2 fixes #822

Merged
merged 51 commits into from
Apr 27, 2020
Merged

Development v2 fixes #822

merged 51 commits into from
Apr 27, 2020

Commits on Apr 3, 2020

  1. Bug: Invalid V in signature with eth_sign (#728)

    * Fix invalid V with metamask/ledger
    
    * DONT FORGET TO REVERT BEFORE MERGING: test deployment
    
    * DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
    
    This reverts commit 8331f2a.
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
    
    This reverts commit 03b81e3.
    mmv08 authored Apr 3, 2020
    Configuration menu
    Copy the full SHA
    94a56d2 View commit details
    Browse the repository at this point in the history
  2. BUG: Only injected providers are cached as last used provider (#733)

    * cache every used provider, not only injected one
    
    * package json update
    mmv08 authored Apr 3, 2020
    Configuration menu
    Copy the full SHA
    727b164 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. (Fix) Adapt app to back-end changes (#736)

    * refactor: Set success status to `201` (CREATED)
    
    * refactor: return `null` when there's no latestTx
    fernandomg authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ba49c97 View commit details
    Browse the repository at this point in the history
  2. (Fix) Transaction not automatically executed (#716)

    * feature: action/reducer to UPDATE_SAFE_NONCE
    
    * refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
    
    * chore: update `yarn.lock`
    
    * refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
    
    * refactor: use `SAFE_REDUCER_ID` constant
    
    * refactor: remove `updateSafeNonce` file
    fernandomg authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    0441ce2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. (Fix) Change the order of the upgrade methods lookup (#740)

    * fix: change the order of the upgrade methods lookup
    
    The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
    The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
    
    * fix: contract upgrade version lookup
    fernandomg authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e33d9fd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Feature: Use eth_sign for hardware wallets connected via onboard.js (#…

    …742)
    
    * Use eth_sign for hardware wallets
    
    * install onboard.js with fix from forked repo
    
    * rebuild yarn.lock to fix cached onboard
    
    * update bnc-onboard
    mmv08 authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    b8bfeab View commit details
    Browse the repository at this point in the history
  2. update package json (#743)

    mmv08 authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    fbc3696 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc68f70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d2f81fc View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. (Fix) Properly decode threshold value in tx details (#749)

    * fix: Display new threshold value when changing its value
    
    There was a typo for the `changeThreshold` action
    
    fixes #746
    
    * refactor: use a constant for safe methods names
    fernandomg authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1ac13c6 View commit details
    Browse the repository at this point in the history
  2. fix: check for decimals method in transferredTokens (#748)

    Previously we were looking for `decimals` hash in the contract `code`.
    There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
    By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
    
    fixes #678
    fernandomg authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b0849ee View commit details
    Browse the repository at this point in the history
  3. Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)

    * don't use getLastTxNonce to fetch safe nonce
    
    * fetch safe nonce in checkAndUpdateSafe
    
    * checkAndUpdateSafe refactor
    
    * remove nonce update logic from UPDATE_SAFE reducer
    
    * handle the case when localSafe returns undefined
    
    * handle the case when localSafe returns undefined in buildTransactionFrom
    
    * bump package json version to 1.9.4
    mmv08 authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b1f50c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4bfe937 View commit details
    Browse the repository at this point in the history
  5. Issue-595: Apps config from Manifest (#715)

    * getting apps info from its manifest
    
    * Consume app info from manifest in Apps list, Transactions and Toast
    
    * fixes
    
    * navigate to TX Tab with an app makes a TX
    nicosampler authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    19dc933 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. (Fix) If backend returns null for addresses the Transaction ca… (#718)

    This tends to solve any possible issue that there may be in the tx execution for the `gasToken` and `refundReceiver` nullish values.
    
    fixes #573
    fernandomg authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    c40fa07 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. #751 fix - Replaces decimals from backend with decimals from blockcha…

    …in (#755)
    
    * Replaces decimals from backend with decimals from blockchain
    
    * Removes fetching again token info from blockchain
    Fixs decimals cast, now we force to move from bignumber to number
    For data already wrong stored as string we remove it to force fetching again the decimals
    
    * Fixs missing symbol
    
    * Add description comment
    Agupane authored Apr 14, 2020
    Configuration menu
    Copy the full SHA
    6bdbcd2 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Added Unilogin provider + support for legacy paths (#719)

    * Added unilogin provier + support for legacy path
    
    * Bump onboardjs version
    matextrem authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a18513a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd85d4a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4956f0e View commit details
    Browse the repository at this point in the history
  4. Create release.yml

    Created script for building desktop app
    matextrem authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7da0e94 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #774 from gnosis/feature/release-script

    Create release.yml
    matextrem authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    2e5d156 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Feature #322: Set safeTxGas for newly created transactions (#752)

    * Set safeTxGas for newly created transactions
    
    * extending estimation for nested calls WIP
    
    * messing up things to implement safeTxGas estimation
    
    * simplifying base gas calculations
    
    * remove eslint disable
    
    * messing things up to make things work
    
    * bring estimateData back
    
    * pass payload to requiredTxGas
    
    * pass esimateData to estimateDataGasCosts
    
    * remove console log
    
    * use batch requests to estimate safeTxGas
    
    * use const for txGasEstimation
    
    * check the response in request simultion
    
    * sidebar fix
    
    * remove for loop
    mmv08 authored Apr 20, 2020
    Configuration menu
    Copy the full SHA
    204edd6 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Manage Apps (#765)

    * getting apps info from its manifest
    
    * Consume app info from manifest in Apps list, Transactions and Toast
    
    * fixes
    
    * navigate to TX Tab with an app makes a TX
    
    * ManageApps partial implementation
    
    * update safe-react-components
    
    * changes
    
    * apps validator
    
    * fix providedBy
    
    * TextField in addApp
    
    * fix checkbox error message
    
    * validation
    
    * adding app
    
    * Manage Apps
    
    * fix modal width
    
    * update package.json
    
    * update netlify url
    
    * fix modal widh
    
    * Set layout to Non-owners allowed error
    
    * some fixes
    
    * Apply suggestions from code review
    
    Co-Authored-By: lukasschor <[email protected]>
    
    * review changes
    
    * fix condition
    
    * Legal Disclaimer
    
    * Better error message
    
    * update yarn.lock
    
    * Error message
    
    * review fixes
    
    * upgrade safe-react-components
    
    * show for all environments
    
    * Disclaimer changes
    
    * review changes
    
    * fix re-render
    
    * visual changes
    
    Co-authored-by: Agustín Longoni <[email protected]>
    Co-authored-by: lukasschor <[email protected]>
    3 people authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    8ba0e18 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Configuration menu
    Copy the full SHA
    035882e View commit details
    Browse the repository at this point in the history
  2. Add region to travis CI develop (#787)

    Enable region for s3 provider to allow upload development environment to different S3 regions
    davizalpe authored Apr 22, 2020
    Configuration menu
    Copy the full SHA
    66dc954 View commit details
    Browse the repository at this point in the history
  3. Feature/travis ci s3 region (#789)

    * Add region to travis CI develop
    
    Enable region for s3 provider to allow upload development environment to different S3 regions
    
    * Enable region for staging s3 providers
    davizalpe authored Apr 22, 2020
    Configuration menu
    Copy the full SHA
    aee2a1f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c5a1e40 View commit details
    Browse the repository at this point in the history
  5. fix error on Wrapper

    alongoni authored Apr 22, 2020
    Configuration menu
    Copy the full SHA
    124a917 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38eb8ab View commit details
    Browse the repository at this point in the history
  7. Merge pull request #791 from gnosis/issue-773

    (Enhancement) #773 Scroll bar in tabs that are not necessary
    alongoni authored Apr 22, 2020
    Configuration menu
    Copy the full SHA
    85f65f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Configuration menu
    Copy the full SHA
    c0422bd View commit details
    Browse the repository at this point in the history
  2. Feature #587 - App performance improvement (#738)

    * Refactor Balances to functional component
    Removes Balances props in Layout.jsx
    
    * Replaces selectors that were using safeParamAddressSelector with safeParamAddressFromStateSelector to avoid the bug of non-loaded safe when called
    Also exports extendedTransactionsSelector to let the components use it
    
    * Refactors Transactions.jsx, replaces transactions.tsx with txsTable.jsx
    Removes all unused props from transactions.jsx
    Makes all childs of txsTable.jsx fetch the props they need instead of sharing all of them even if they are not used
    
    * Adds new selectors: safeNameSelector, safeNeedsUpdateSelector, safeCurrentVersionSelector
    
    * Removes unused props from layout to settings.jsx
    Removed props from the settings.jsx childs, now they fetch the values they need directly from the store
    
    * Removes unused redux connect
    
    * Adds safeEthBalanceSelector
    
    * Removes all the props from layout to settings
    
    * Refactor root and layout, extracts checkForUpdate and componentDidMount to components
    Extracts header and tabs from Layout.jsx
    
    * Makes routes.jsx use selectors instead of connect to unify the code
    
    * Loads tabs components using react suspense
    
    * Fixs warning when trying to update root component within loadStore.jsx
    Replaces safe with safeAddress selector in layout.jsx to reduce the unnecessary rendering
    Fixs setState in container.jsx
    
    * Fixs checkForUpdates fetchTokenBalances
    Adds FetchTokens.jsx in balances
    Adds safeFeaturesEnabledSelector
    
    * Fixs load addressbook action
    
    * Replaces safe with owners in manage owners
    
    * Improves buildSafe promises calls
    Improves the loadStorage calls
    
    * Fixs error "Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined"
    
    * Extracts LoadStore from outside the router component to avoid re-loading the store
    Adds react lazy for Coins and Collectible tabs
    
    * Reduce the polling rate for fetching transactions
    
    * Removes unused actions.js
    Removes unused selector props
    
    * Fixes owners column selector usage
    
    * Fixes processTransaction usage
    
    * Optimize how the transaction list within the transactions tab are loaded
    
    * Fix lint error
    
    * Fix edit addressbook entry
    
    * Fixs show send coins modal
    
    * feature: batchRequest for incoming transactions
    
    * Fixs race condition on loadStore
    Fixs check for updates address null validation
    
    * Adds ensureOnceAsync for getGnosisSafeInstanceAt
    Adds batch request for safe params
    
    * Removes unnecessary checkAndUpdateSafe from checkForUpdates, now the safe gets updated when a transaction arrives
    
    * Fixs ensureOnce/memoization
    
    * refactor: make a generic generateBatchRequest method
    
    Create a generic method to easily build web3 batch requests
    
    * refactor: use `generateBatchRequest` in `getTokensBalances`
    
    * Removes .toJS in edit entry
    
    * Removes web3 from sendTransactions
    Removes pascal case FetchTokens
    
    * Replaces /layout import
    
    * Replaces CheckForUpdates component with useCheckForUpdates hook
    
    * Makes FetchTokens a hook
    
    * Removes getSafeParamsBatch, now the safes gets the data using the generic generateBatchRequests
    
    * Replaces INITIAL_STATUS with INITIAL_STATE
    
    * Replaces regex
    Adds spaces before return
    
    * Adds wrapInSuspense
    
    * Runs prettier
    
    * Makes checkAndUpdateSafe use generateBatchRequests
    
    * Makes checkAndUpdateSafe use generateBatchRequests
    
    * Fixs check for updates with null address
    
    * Fixs transaction details getNameFromAddressBook
    
    * Fixes zIndex between cookies banner and transaction details
    
    * fix: cast returned values to number
    
    Original code was expecting a BN instance, now it's a plain string.
    
    * Fix replace owner name
    
    * Fix race condition with adbk load
    
    * Fixes replaces owner
    
    * Fixs apps
    
    * Moved hooks into own folder
    
    * Moved LoadStore to routes.js
    Refactors LoadStore as Hook
    Move LoadStore to hooks folder
    
    * Moves useLoadStore to safes/index
    
    * Revert loadStore place change
    
    * Fixes bug with fetchEtherBalance that causes updateSafe to be called
    
    * remove useLoadStore, add useAnalytics hook
    
    * remove React.memo from SafeView
    
    * Reverts removing useLoadStore in order to maintain the consistency of the code
    
    * rewrite useLoadStore in a more hook-y way, rename it to useLoadSafe
    
    * Removes unnecessary setSafeLoaded
    
    * Removes unnecessary safeLoaded
    
    * fix: Coins values and balances
    
    The app was retrieving ERC20 tokens information from 3 different endpoints.
     - One from `balance/` to have the list updated
     - another from `balance/usd` to have the values in USD
     - the last one from the blockchain, to update the balances
    This was all simplified to `balance/usd`.
    
    Also, added a `currencyRate` to be updated when the currency is modified.
    
    The value calculation happens on a component level, so when the `balanceUsd` value is modified, the value is properly reflected on the screen.
    
    Refactored `activateTokensByBalance` to `fetchSafeTokens`, as this was doing quite more than just _activating_ and also added the `currencyList` calculation in it, so everything is updated when `balance/usd` endpoint is requested.
    
    * fix: Balance screen
    
    Collectibles weren't loading when clicking on the link
    
    Also, refactored setState usage, to properly update current state
    
    * fix: featuresEnabled undefined
    
    * fix: add/activate newly received tokens
    
    * fix: NaN Values in Coins for a newly loaded Safe
    
    Was failing to set a default value for the `currencyRate`
    
    * fix: Settings fails to load if `owners` is not loaded into store
    
    Added a `Loader` until the required Safe's data is loaded into store.
    
    * fix: prefetch txs data
    
    When building the Txs list, we requested data for every tx what was translated into several RPC calls.
    
    Now by _batchRequesting_ all the information on beforehand, Safe's loading is a bit faster.
    
    * fix: prevent requesting safe, when there's no safe available in the store
    
    * enhancement: fetch tokens when loading safe
    
    By doing this, when loading a safe in the balance screen we will have tokens immediately loaded into the coins list
    
    * fix: load collectibles when switch to collectibles screen
    
    Collectibles weren't loaded when clicking menu link for a newly loaded safe.
    
    Now every switch to the collectible's screen will trigger a fetch for collectibles.
    
    * fix: fetch only if safe is ready
    
    Co-authored-by: fernandomg <[email protected]>
    Co-authored-by: Mikhail Mikheev <[email protected]>
    3 people authored Apr 23, 2020
    Configuration menu
    Copy the full SHA
    9d78492 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Fix (#777)

    nicosampler authored Apr 24, 2020
    Configuration menu
    Copy the full SHA
    162ff84 View commit details
    Browse the repository at this point in the history
  2. fix: batchRequest params order

    fernandomg authored and mmv08 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    0cd526f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    edcfd2e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b46af65 View commit details
    Browse the repository at this point in the history
  5. Uses formatAmount

    Agupane authored and mmv08 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    d91f403 View commit details
    Browse the repository at this point in the history
  6. Removes unused code

    Fixs params props safe address form
    Agupane authored and mmv08 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    75418eb View commit details
    Browse the repository at this point in the history
  7. Fixs composeValidators

    Adds composeValidators for apps section
    Agupane authored and mmv08 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    8da025c View commit details
    Browse the repository at this point in the history
  8. Makes composeValidatorsApps a wrapper

    Agupane authored and mmv08 committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    74d9ce7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5cbb8f5 View commit details
    Browse the repository at this point in the history
  10. Desktop app (#745)

    * Set up electron app
    
    * Update dependencies
    
    * Update package.json
    
    * Added https support
    
    * Add support for Ledger
    
    * Updated certs
    
    * Added auto updates messages
    
    * Update auto-updater method
    
    * Update package.json
    
    * Added build resources
    
    * Update preload
    
    * Update Ledger method on mac
    
    * Update build
    
    * Merge with develop
    
    * Added support for Portis
    
    * Fix electron error and updater
    
    * Update auto updater
    
    * Fix dependencies
    
    * Merge with develop
    
    * Change auto update functionality
    
    * Edit package.json and added github actions
    
    * Updated github actions
    
    * Fixed Torus + Update github actions
    
    * Updated release.yml
    
    * Try only ubuntu
    
    * Update package.json
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * Updated safe-contracts
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * Updated deploy branch
    
    * Updated script
    
    Co-authored-by: Mati Dastugue <[email protected]>
    matextrem and Mati Dastugue authored Apr 24, 2020
    Configuration menu
    Copy the full SHA
    c57885d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    22f31b1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    281c3c6 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #808 from gnosis/fix/release-apps

    Update yarn script + SAFE_APPS env variable
    matextrem authored Apr 24, 2020
    Configuration menu
    Copy the full SHA
    8c91e02 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Configuration menu
    Copy the full SHA
    f4cca4c View commit details
    Browse the repository at this point in the history
  2. SafeTxGas calculation: Add check for openethereum/parity revert messa…

    …ges (#788)
    
    * add check for openethereum/parity revert messages
    
    * fix isEstimationSuccessful check
    
    * fix estimation check if revert msg is from openethereum
    mmv08 authored Apr 27, 2020
    Configuration menu
    Copy the full SHA
    76c673a View commit details
    Browse the repository at this point in the history
  3. Issue 796 (#807)

    * consume gnosis componentes from npm
    
    * set safe-apps url from environment variable
    
    * fix apps padding and border radius
    
    * Apps updates
    
    * update disclaimer
    
    * fix Loader in TXList
    
    * Fix invalid origin
    
    Co-authored-by: Agustín Longoni <[email protected]>
    nicosampler and alongoni authored Apr 27, 2020
    Configuration menu
    Copy the full SHA
    5014e86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    653f68b View commit details
    Browse the repository at this point in the history
  5. Fix master conflicts (#819)

    * v2.0.0 (#806)
    
    * Bug: Invalid V in signature with eth_sign (#728)
    
    * Fix invalid V with metamask/ledger
    
    * DONT FORGET TO REVERT BEFORE MERGING: test deployment
    
    * DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
    
    This reverts commit 8331f2a.
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
    
    This reverts commit 03b81e3.
    
    * BUG: Only injected providers are cached as last used provider (#733)
    
    * cache every used provider, not only injected one
    
    * package json update
    
    * (Fix) Adapt app to back-end changes (#736)
    
    * refactor: Set success status to `201` (CREATED)
    
    * refactor: return `null` when there's no latestTx
    
    * (Fix) Transaction not automatically executed (#716)
    
    * feature: action/reducer to UPDATE_SAFE_NONCE
    
    * refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
    
    * chore: update `yarn.lock`
    
    * refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
    
    * refactor: use `SAFE_REDUCER_ID` constant
    
    * refactor: remove `updateSafeNonce` file
    
    * (Fix) Change the order of the upgrade methods lookup (#740)
    
    * fix: change the order of the upgrade methods lookup
    
    The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
    The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
    
    * fix: contract upgrade version lookup
    
    * Feature: Use eth_sign for hardware wallets connected via onboard.js (#742)
    
    * Use eth_sign for hardware wallets
    
    * install onboard.js with fix from forked repo
    
    * rebuild yarn.lock to fix cached onboard
    
    * update bnc-onboard
    
    * update package json (#743)
    
    * (Fix) Properly decode threshold value in tx details (#749)
    
    * fix: Display new threshold value when changing its value
    
    There was a typo for the `changeThreshold` action
    
    fixes #746
    
    * refactor: use a constant for safe methods names
    
    * fix: check for `decimals` method in transferredTokens (#748)
    
    Previously we were looking for `decimals` hash in the contract `code`.
    There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
    By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
    
    fixes #678
    
    * Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)
    
    * don't use getLastTxNonce to fetch safe nonce
    
    * fetch safe nonce in checkAndUpdateSafe
    
    * checkAndUpdateSafe refactor
    
    * remove nonce update logic from UPDATE_SAFE reducer
    
    * handle the case when localSafe returns undefined
    
    * handle the case when localSafe returns undefined in buildTransactionFrom
    
    * bump package json version to 1.9.4
    
    * Issue-595: Apps config from Manifest (#715)
    
    * getting apps info from its manifest
    
    * Consume app info from manifest in Apps list, Transactions and Toast
    
    * fixes
    
    * navigate to TX Tab with an app makes a TX
    
    * (Fix) If backend returns `null` for addresses the Transaction ca… (#718)
    
    This tends to solve any possible issue that there may be in the tx execution for the `gasToken` and `refundReceiver` nullish values.
    
    fixes #573
    
    * #751 fix - Replaces decimals from backend with decimals from blockchain (#755)
    
    * Replaces decimals from backend with decimals from blockchain
    
    * Removes fetching again token info from blockchain
    Fixs decimals cast, now we force to move from bignumber to number
    For data already wrong stored as string we remove it to force fetching again the decimals
    
    * Fixs missing symbol
    
    * Add description comment
    
    * Added Unilogin provider + support for legacy paths (#719)
    
    * Added unilogin provier + support for legacy path
    
    * Bump onboardjs version
    
    * fallback to displaying custom tx when we fail to fetch token info (#767)
    
    * Create release.yml
    
    Created script for building desktop app
    
    * Feature #322: Set safeTxGas for newly created transactions (#752)
    
    * Set safeTxGas for newly created transactions
    
    * extending estimation for nested calls WIP
    
    * messing up things to implement safeTxGas estimation
    
    * simplifying base gas calculations
    
    * remove eslint disable
    
    * messing things up to make things work
    
    * bring estimateData back
    
    * pass payload to requiredTxGas
    
    * pass esimateData to estimateDataGasCosts
    
    * remove console log
    
    * use batch requests to estimate safeTxGas
    
    * use const for txGasEstimation
    
    * check the response in request simultion
    
    * sidebar fix
    
    * remove for loop
    
    * Manage Apps (#765)
    
    * getting apps info from its manifest
    
    * Consume app info from manifest in Apps list, Transactions and Toast
    
    * fixes
    
    * navigate to TX Tab with an app makes a TX
    
    * ManageApps partial implementation
    
    * update safe-react-components
    
    * changes
    
    * apps validator
    
    * fix providedBy
    
    * TextField in addApp
    
    * fix checkbox error message
    
    * validation
    
    * adding app
    
    * Manage Apps
    
    * fix modal width
    
    * update package.json
    
    * update netlify url
    
    * fix modal widh
    
    * Set layout to Non-owners allowed error
    
    * some fixes
    
    * Apply suggestions from code review
    
    Co-Authored-By: lukasschor <[email protected]>
    
    * review changes
    
    * fix condition
    
    * Legal Disclaimer
    
    * Better error message
    
    * update yarn.lock
    
    * Error message
    
    * review fixes
    
    * upgrade safe-react-components
    
    * show for all environments
    
    * Disclaimer changes
    
    * review changes
    
    * fix re-render
    
    * visual changes
    
    Co-authored-by: Agustín Longoni <[email protected]>
    Co-authored-by: lukasschor <[email protected]>
    
    * fix scroll and fix margin layout
    
    * Add region to travis CI develop (#787)
    
    Enable region for s3 provider to allow upload development environment to different S3 regions
    
    * Feature/travis ci s3 region (#789)
    
    * Add region to travis CI develop
    
    Enable region for s3 provider to allow upload development environment to different S3 regions
    
    * Enable region for staging s3 providers
    
    * fix error on Wrapper
    
    * Add gnosis wc bridge to onboard.js wallets options array (#790)
    
    * Rename incoming-transactions url to incoming-transfers
    
    * Feature #587 - App performance improvement (#738)
    
    * Refactor Balances to functional component
    Removes Balances props in Layout.jsx
    
    * Replaces selectors that were using safeParamAddressSelector with safeParamAddressFromStateSelector to avoid the bug of non-loaded safe when called
    Also exports extendedTransactionsSelector to let the components use it
    
    * Refactors Transactions.jsx, replaces transactions.tsx with txsTable.jsx
    Removes all unused props from transactions.jsx
    Makes all childs of txsTable.jsx fetch the props they need instead of sharing all of them even if they are not used
    
    * Adds new selectors: safeNameSelector, safeNeedsUpdateSelector, safeCurrentVersionSelector
    
    * Removes unused props from layout to settings.jsx
    Removed props from the settings.jsx childs, now they fetch the values they need directly from the store
    
    * Removes unused redux connect
    
    * Adds safeEthBalanceSelector
    
    * Removes all the props from layout to settings
    
    * Refactor root and layout, extracts checkForUpdate and componentDidMount to components
    Extracts header and tabs from Layout.jsx
    
    * Makes routes.jsx use selectors instead of connect to unify the code
    
    * Loads tabs components using react suspense
    
    * Fixs warning when trying to update root component within loadStore.jsx
    Replaces safe with safeAddress selector in layout.jsx to reduce the unnecessary rendering
    Fixs setState in container.jsx
    
    * Fixs checkForUpdates fetchTokenBalances
    Adds FetchTokens.jsx in balances
    Adds safeFeaturesEnabledSelector
    
    * Fixs load addressbook action
    
    * Replaces safe with owners in manage owners
    
    * Improves buildSafe promises calls
    Improves the loadStorage calls
    
    * Fixs error "Uncaught (in promise) TypeError: Cannot read property 'includes' of undefined"
    
    * Extracts LoadStore from outside the router component to avoid re-loading the store
    Adds react lazy for Coins and Collectible tabs
    
    * Reduce the polling rate for fetching transactions
    
    * Removes unused actions.js
    Removes unused selector props
    
    * Fixes owners column selector usage
    
    * Fixes processTransaction usage
    
    * Optimize how the transaction list within the transactions tab are loaded
    
    * Fix lint error
    
    * Fix edit addressbook entry
    
    * Fixs show send coins modal
    
    * feature: batchRequest for incoming transactions
    
    * Fixs race condition on loadStore
    Fixs check for updates address null validation
    
    * Adds ensureOnceAsync for getGnosisSafeInstanceAt
    Adds batch request for safe params
    
    * Removes unnecessary checkAndUpdateSafe from checkForUpdates, now the safe gets updated when a transaction arrives
    
    * Fixs ensureOnce/memoization
    
    * refactor: make a generic generateBatchRequest method
    
    Create a generic method to easily build web3 batch requests
    
    * refactor: use `generateBatchRequest` in `getTokensBalances`
    
    * Removes .toJS in edit entry
    
    * Removes web3 from sendTransactions
    Removes pascal case FetchTokens
    
    * Replaces /layout import
    
    * Replaces CheckForUpdates component with useCheckForUpdates hook
    
    * Makes FetchTokens a hook
    
    * Removes getSafeParamsBatch, now the safes gets the data using the generic generateBatchRequests
    
    * Replaces INITIAL_STATUS with INITIAL_STATE
    
    * Replaces regex
    Adds spaces before return
    
    * Adds wrapInSuspense
    
    * Runs prettier
    
    * Makes checkAndUpdateSafe use generateBatchRequests
    
    * Makes checkAndUpdateSafe use generateBatchRequests
    
    * Fixs check for updates with null address
    
    * Fixs transaction details getNameFromAddressBook
    
    * Fixes zIndex between cookies banner and transaction details
    
    * fix: cast returned values to number
    
    Original code was expecting a BN instance, now it's a plain string.
    
    * Fix replace owner name
    
    * Fix race condition with adbk load
    
    * Fixes replaces owner
    
    * Fixs apps
    
    * Moved hooks into own folder
    
    * Moved LoadStore to routes.js
    Refactors LoadStore as Hook
    Move LoadStore to hooks folder
    
    * Moves useLoadStore to safes/index
    
    * Revert loadStore place change
    
    * Fixes bug with fetchEtherBalance that causes updateSafe to be called
    
    * remove useLoadStore, add useAnalytics hook
    
    * remove React.memo from SafeView
    
    * Reverts removing useLoadStore in order to maintain the consistency of the code
    
    * rewrite useLoadStore in a more hook-y way, rename it to useLoadSafe
    
    * Removes unnecessary setSafeLoaded
    
    * Removes unnecessary safeLoaded
    
    * fix: Coins values and balances
    
    The app was retrieving ERC20 tokens information from 3 different endpoints.
     - One from `balance/` to have the list updated
     - another from `balance/usd` to have the values in USD
     - the last one from the blockchain, to update the balances
    This was all simplified to `balance/usd`.
    
    Also, added a `currencyRate` to be updated when the currency is modified.
    
    The value calculation happens on a component level, so when the `balanceUsd` value is modified, the value is properly reflected on the screen.
    
    Refactored `activateTokensByBalance` to `fetchSafeTokens`, as this was doing quite more than just _activating_ and also added the `currencyList` calculation in it, so everything is updated when `balance/usd` endpoint is requested.
    
    * fix: Balance screen
    
    Collectibles weren't loading when clicking on the link
    
    Also, refactored setState usage, to properly update current state
    
    * fix: featuresEnabled undefined
    
    * fix: add/activate newly received tokens
    
    * fix: NaN Values in Coins for a newly loaded Safe
    
    Was failing to set a default value for the `currencyRate`
    
    * fix: Settings fails to load if `owners` is not loaded into store
    
    Added a `Loader` until the required Safe's data is loaded into store.
    
    * fix: prefetch txs data
    
    When building the Txs list, we requested data for every tx what was translated into several RPC calls.
    
    Now by _batchRequesting_ all the information on beforehand, Safe's loading is a bit faster.
    
    * fix: prevent requesting safe, when there's no safe available in the store
    
    * enhancement: fetch tokens when loading safe
    
    By doing this, when loading a safe in the balance screen we will have tokens immediately loaded into the coins list
    
    * fix: load collectibles when switch to collectibles screen
    
    Collectibles weren't loaded when clicking menu link for a newly loaded safe.
    
    Now every switch to the collectible's screen will trigger a fetch for collectibles.
    
    * fix: fetch only if safe is ready
    
    Co-authored-by: fernandomg <[email protected]>
    Co-authored-by: Mikhail Mikheev <[email protected]>
    
    * Fix (#777)
    
    * fix: batchRequest params order
    
    * fix: execute decodeParams for all sendTokenTxs
    
    * fix: proper amount display for tx in TxTable
    
    * Uses formatAmount
    
    * Removes unused code
    Fixs params props safe address form
    
    * Fixs composeValidators
    Adds composeValidators for apps section
    
    * Makes composeValidatorsApps a wrapper
    
    * Moves composeValidatorsApps to managesApps.js
    
    * Desktop app (#745)
    
    * Set up electron app
    
    * Update dependencies
    
    * Update package.json
    
    * Added https support
    
    * Add support for Ledger
    
    * Updated certs
    
    * Added auto updates messages
    
    * Update auto-updater method
    
    * Update package.json
    
    * Added build resources
    
    * Update preload
    
    * Update Ledger method on mac
    
    * Update build
    
    * Merge with develop
    
    * Added support for Portis
    
    * Fix electron error and updater
    
    * Update auto updater
    
    * Fix dependencies
    
    * Merge with develop
    
    * Change auto update functionality
    
    * Edit package.json and added github actions
    
    * Updated github actions
    
    * Fixed Torus + Update github actions
    
    * Updated release.yml
    
    * Try only ubuntu
    
    * Update package.json
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * Updated safe-contracts
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * v1.9.6
    
    * Updated deploy branch
    
    * Updated script
    
    Co-authored-by: Mati Dastugue <[email protected]>
    
    Co-authored-by: Fernando <[email protected]>
    Co-authored-by: nicolas <[email protected]>
    Co-authored-by: Agustin Pane <[email protected]>
    Co-authored-by: Mati Dastugue <[email protected]>
    Co-authored-by: Agustín Longoni <[email protected]>
    Co-authored-by: lukasschor <[email protected]>
    Co-authored-by: David Albela Pérez <[email protected]>
    Co-authored-by: Uxio Fuentefria <[email protected]>
    Co-authored-by: Mati Dastugue <[email protected]>
    
    * Update CI Desktop script
    
    * Update CI script for windows
    
    Co-authored-by: Mikhail Mikheev <[email protected]>
    Co-authored-by: Fernando <[email protected]>
    Co-authored-by: Agustin Pane <[email protected]>
    Co-authored-by: Mati Dastugue <[email protected]>
    Co-authored-by: Agustín Longoni <[email protected]>
    Co-authored-by: lukasschor <[email protected]>
    Co-authored-by: David Albela Pérez <[email protected]>
    Co-authored-by: Uxio Fuentefria <[email protected]>
    Co-authored-by: Mati Dastugue <[email protected]>
    10 people authored Apr 27, 2020
    Configuration menu
    Copy the full SHA
    9363485 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1388daa View commit details
    Browse the repository at this point in the history