fix: better network comparison + WC peer tracking #3729
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
| @@ -15,7 +15,7 @@ export const onConnectButtonClick = async (): Promise<void> => { | |||
| } | |||
|
|
|||
| const ConnectButton = (props: { 'data-testid': string }): ReactElement => ( | |||
| <Track {...OVERVIEW_EVENTS.ONBOARD}> | |||
| <Track {...OVERVIEW_EVENTS.OPEN_ONBOARD}> | |||
There was a problem hiding this comment.
This was not the correct event key.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| if (payload === account) { | ||
| trackEvent({ ...WALLET_EVENTS.CONNECT, label: name }) | ||
| // Only track when store/UI is in sync with onboard | ||
| if (account === checksumAddress(address) && !shouldSwitchNetwork(wallet)) { |
There was a problem hiding this comment.
The address retrieved from onboard's state is not checksummed.
|
Note: I had a clarification about switching accounts. I was exepcting at fist see an event "switch account" or something like that, but no, there is a new "connect" event instead. This is fine Looks good to me. Connecting: Switching accounts in the MM phone app: Switching from rin: to eth: and back: Connecting with a safe as owner: |
Pull Request Test Coverage Report for Build 2059294936
💛 - Coveralls |
What it solves
Resolves #2812 + #3579
How this PR fixes it
The name of the WalletConnect peer is now tracked in the provider middleware alongside the connected wallet when the user is connected to a network.
shouldSwitchNetworkwas improved to prevent this from being over-tracked.How to test it
Connect to the Safe via MM as an example and observe the following wallet tracking:
The WC peer should be tracked in the same instances.
The "Switch wallet to {{chainName}}" button should continue to work as before.
Analytics changes
The WC peer name should now be tracked, tracking as 'Unknown' if one doesn't exist.
Screenshots