shouldSwitchNetwork is not provider agnostic

[iamacook]

tl;dr

In MM chainId is a hex, in WC a number. Need to handle. Convert to a numberified string.

Description

shouldSwitchNetwork references the provider of Onboard's wallet instance. However, it seems as there is no universal chainId value that we can reference across all providers.

The original version of shouldSwitchNetwork checked networkVersion, which is MetaMask-specific (although likely other providers as well. As part of the desktop pairing implementation (also affecting WC), it was extended to check chainId as well.

Subsequently, it has been noticed that there is no 'standard' across these two keys (maybe there are also other keys with other providers), e.g.

WC

  const provider = {
    chainId: 4 // integer
    ...
  }

MM

  const provider = {
    chainId: "0x04", // hex
    networkVersion: "4" // string
    ...
  }

We need a way of consistently checking against a standard key that the current chainId matches that, perhaps comparing an integer, string and hex value of it.

Expected result

shouldSwitchNetwork returns a consistent boolean back across all chains when the chain needs to be switched.

Obtained result

It is not always consistent.

[katspaugh]

A mind-blowing find. 🤦