This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
USD value doesn't load #597
Assignees
Comments
lukasschor
added
Bug 🐛
|
Related to #533 |
|
I forgot to let a message here, I did tiny research around this and found that, indeed, we are not checksumming the addresses before querying the API. Tested it locally, and, while I was able to fix the issue with the listed endpoint, then I got the same So the better will be to store the address checksummed in our redux store, instead of converting it before any backend request. |
Agupane
added a commit
that referenced
this issue
Feb 21, 2020
Merged
mmv08
added a commit
that referenced
this issue
Feb 26, 2020
* Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
mmv08
added a commit
that referenced
this issue
Feb 28, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]>
mmv08
added a commit
that referenced
this issue
Mar 6, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
fernandomg
added a commit
that referenced
this issue
Mar 9, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
fernandomg
added a commit
that referenced
this issue
Mar 9, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
mmv08
added a commit
that referenced
this issue
Mar 9, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> * (feature): [Safe Apps] App Transaction List Details (#601) * Adding IconText component * Get origin for TXs in Redux * Adding Icon and name app to transaction list * Fix customTx condition * Fix HTML element for text * simplify condition * Bug: Accounts/Network are not updated in production build (#625) * Adding Apps info to toast notification (#621) * Adding APP_Name for APPs TXs in toast messages * refactor: save appId instead of appName in origin field * adding fallback icon and message to TX apps table * review changes * review fixes * force build * update Apps list info (#629) * update Apps list info * fix * Feature: replace web3connect with onboardjs (#456) * init onboard.js * dep bump * initial replacement of web3connect with onboard.js * use averta font in the modal * update onboard.js, add handlers for session murder * update preferred wallets * implement reconnecting to injected provider * fix duplicate wallet disconnected notification * update onboard dep * onboardjs fixes * test onboard js with hw * add https to rpcUrl * Added saved wallet and transactions validation * made Transactions validation * bnc-onboard version updated * Fix lock/unlock problem * bump onboardjs version * fixed material-ui lab version * Update onboard version * Added hw wallets integration * Updated preferred wallets * Add ledger modal * Merge with dev * Update onboard * BUmp new version of onboardjs * Added some logs * Added some logs * Update onboardjs version fix ledger connection * Update onboardjs version fix ledger connection * Bump new onboardjs version * Update new version * Made improvements * yarn.lock regenration * remove https=true * Remove comments and added some improvements * Updated package.json dep * Removed unused deps * Remove web3connect dep Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> * Passing ethBalance to Apps component (#636) * (Fix) Update safe modal verbiage (#633) * Fixs verbiage in update safe modal * Fixs yarn lock * Bump dependencies (#639) * Use hash history (#638) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * - Updates how the transactions are ordered, now orders by nonce and then by date (#640) * (Fix) Lowercased safes address in URL (#631) * Return checksummed addrress from `safeParamAddressFromState` selector * Update `yarn.lock` * Remove redundant `toChecksumAddress` call Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]> Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: francovenica <[email protected]>
mmv08
added a commit
that referenced
this issue
Mar 11, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
mmv08
added a commit
that referenced
this issue
Mar 11, 2020
* Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> * Rebase master onto development (#624) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]> * (feature): [Safe Apps] App Transaction List Details (#601) * Adding IconText component * Get origin for TXs in Redux * Adding Icon and name app to transaction list * Fix customTx condition * Fix HTML element for text * simplify condition * Bug: Accounts/Network are not updated in production build (#625) * Adding Apps info to toast notification (#621) * Adding APP_Name for APPs TXs in toast messages * refactor: save appId instead of appName in origin field * adding fallback icon and message to TX apps table * review changes * review fixes * force build * update Apps list info (#629) * update Apps list info * fix * Feature: replace web3connect with onboardjs (#456) * init onboard.js * dep bump * initial replacement of web3connect with onboard.js * use averta font in the modal * update onboard.js, add handlers for session murder * update preferred wallets * implement reconnecting to injected provider * fix duplicate wallet disconnected notification * update onboard dep * onboardjs fixes * test onboard js with hw * add https to rpcUrl * Added saved wallet and transactions validation * made Transactions validation * bnc-onboard version updated * Fix lock/unlock problem * bump onboardjs version * fixed material-ui lab version * Update onboard version * Added hw wallets integration * Updated preferred wallets * Add ledger modal * Merge with dev * Update onboard * BUmp new version of onboardjs * Added some logs * Added some logs * Update onboardjs version fix ledger connection * Update onboardjs version fix ledger connection * Bump new onboardjs version * Update new version * Made improvements * yarn.lock regenration * remove https=true * Remove comments and added some improvements * Updated package.json dep * Removed unused deps * Remove web3connect dep Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> * Passing ethBalance to Apps component (#636) * (Fix) Update safe modal verbiage (#633) * Fixs verbiage in update safe modal * Fixs yarn lock * Bump dependencies (#639) * Use hash history (#638) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * - Updates how the transactions are ordered, now orders by nonce and then by date (#640) * (Fix) Lowercased safes address in URL (#631) * Return checksummed addrress from `safeParamAddressFromState` selector * Update `yarn.lock` * Remove redundant `toChecksumAddress` call Co-authored-by: Mikhail Mikheev <[email protected]> * Rebase master into development (#647) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> * (feature): [Safe Apps] App Transaction List Details (#601) * Adding IconText component * Get origin for TXs in Redux * Adding Icon and name app to transaction list * Fix customTx condition * Fix HTML element for text * simplify condition * Bug: Accounts/Network are not updated in production build (#625) * Adding Apps info to toast notification (#621) * Adding APP_Name for APPs TXs in toast messages * refactor: save appId instead of appName in origin field * adding fallback icon and message to TX apps table * review changes * review fixes * force build * update Apps list info (#629) * update Apps list info * fix * Feature: replace web3connect with onboardjs (#456) * init onboard.js * dep bump * initial replacement of web3connect with onboard.js * use averta font in the modal * update onboard.js, add handlers for session murder * update preferred wallets * implement reconnecting to injected provider * fix duplicate wallet disconnected notification * update onboard dep * onboardjs fixes * test onboard js with hw * add https to rpcUrl * Added saved wallet and transactions validation * made Transactions validation * bnc-onboard version updated * Fix lock/unlock problem * bump onboardjs version * fixed material-ui lab version * Update onboard version * Added hw wallets integration * Updated preferred wallets * Add ledger modal * Merge with dev * Update onboard * BUmp new version of onboardjs * Added some logs * Added some logs * Update onboardjs version fix ledger connection * Update onboardjs version fix ledger connection * Bump new onboardjs version * Update new version * Made improvements * yarn.lock regenration * remove https=true * Remove comments and added some improvements * Updated package.json dep * Removed unused deps * Remove web3connect dep Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> * Passing ethBalance to Apps component (#636) * (Fix) Update safe modal verbiage (#633) * Fixs verbiage in update safe modal * Fixs yarn lock * Bump dependencies (#639) * Use hash history (#638) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * - Updates how the transactions are ordered, now orders by nonce and then by date (#640) * (Fix) Lowercased safes address in URL (#631) * Return checksummed addrress from `safeParamAddressFromState` selector * Update `yarn.lock` * Remove redundant `toChecksumAddress` call Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]> Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: francovenica <[email protected]> * Update safe relay and transaction endpoints * Master into development (#655) * Fix NODE_ENV development definition - Define develop build for development branches. - Use POSIX standard to call shell scripts in travis file. * Mark travis shell scripts as executable * Fix conditional statement at travis build.sh file * Set development endpoints to stable staging backends * Sync master dev (#656) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]> Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: francovenica <[email protected]> Co-authored-by: Richard Meissner <[email protected]>
fernandomg
pushed a commit
that referenced
this issue
Mar 18, 2020
fernandomg
added a commit
that referenced
this issue
Mar 18, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]>
fernandomg
added a commit
that referenced
this issue
Mar 18, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
fernandomg
added a commit
that referenced
this issue
Mar 18, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> * Bug: #482 - Address book Custom transactions Recipient validation (#577) * (fix) text input bottom border * Fix #482 input * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # src/components/forms/TextField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/TokenSelectField/index.jsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.jsx # yarn.lock * Fix custom tx addresses filtering * Merge branch 'development' of https://github.com/gnosis/safe-react into fix/#482-address-book # Conflicts: # yarn.lock * Remove console logs Fixed prettier issues * Remove unnecessary template string * Fix `tokenAddress` string conversion * Use `secondaryBackground` value Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: Fernando <[email protected]> * (feature) Adding origin for Apps Transactions (#576) * Adding origin field when creates a TX * refactor: replace list of arg by object in getApprovalTransaction and getExecutionTransaction function * minor changes * Allow execute if threshold is 1 for the first tx - Related to issue #563 - `lastTx` is required due to #489 * - Normalizing logic between createTransaction and processTransaction - Moving shared function to a new file * Refactor `doesTxNeedApproval` back to the `isExecution`-related meaning * Rename function and variable names * Add tests for `getNewTxNonce` and `shouldExecuteTransaction` functions * Pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` * Update Tests - remove mocked `getGnosisSafeInstanceAt` - pass `safeInstance` instead of `safeAddress` to `getNewTxNonce` Co-authored-by: Fernando <[email protected]> * (Feature) Add checks into CI (#594) * Repare new dev and staging enviroments to deploy (#618) * Repare new dev and staging enviroments to deploy - Add to `deploy_pull_requests.sh` to the new path. - Replace upload-dir to deploy staging to the new path. * add /app/ public path for the webapp, remove duplicate yarn build from travis * add basename to app * deploy pr to /app * update travis * linter error fixes * fix travis build script Co-authored-by: David Albela Pérez <[email protected]> * (fix) sidebar contents' scrolling (#622) * (add) linter sorting rules (#614) * (add) linter sorting rules * (fix) linting errors according to the new rules Co-authored-by: Fernando <[email protected]> * (feature): [Safe Apps] App Transaction List Details (#601) * Adding IconText component * Get origin for TXs in Redux * Adding Icon and name app to transaction list * Fix customTx condition * Fix HTML element for text * simplify condition * Bug: Accounts/Network are not updated in production build (#625) * Adding Apps info to toast notification (#621) * Adding APP_Name for APPs TXs in toast messages * refactor: save appId instead of appName in origin field * adding fallback icon and message to TX apps table * review changes * review fixes * force build * update Apps list info (#629) * update Apps list info * fix * Feature: replace web3connect with onboardjs (#456) * init onboard.js * dep bump * initial replacement of web3connect with onboard.js * use averta font in the modal * update onboard.js, add handlers for session murder * update preferred wallets * implement reconnecting to injected provider * fix duplicate wallet disconnected notification * update onboard dep * onboardjs fixes * test onboard js with hw * add https to rpcUrl * Added saved wallet and transactions validation * made Transactions validation * bnc-onboard version updated * Fix lock/unlock problem * bump onboardjs version * fixed material-ui lab version * Update onboard version * Added hw wallets integration * Updated preferred wallets * Add ledger modal * Merge with dev * Update onboard * BUmp new version of onboardjs * Added some logs * Added some logs * Update onboardjs version fix ledger connection * Update onboardjs version fix ledger connection * Bump new onboardjs version * Update new version * Made improvements * yarn.lock regenration * remove https=true * Remove comments and added some improvements * Updated package.json dep * Removed unused deps * Remove web3connect dep Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> * Passing ethBalance to Apps component (#636) * (Fix) Update safe modal verbiage (#633) * Fixs verbiage in update safe modal * Fixs yarn lock * Bump dependencies (#639) * Use hash history (#638) * v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * use hash history Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * - Updates how the transactions are ordered, now orders by nonce and then by date (#640) * (Fix) Lowercased safes address in URL (#631) * Return checksummed addrress from `safeParamAddressFromState` selector * Update `yarn.lock` * Remove redundant `toChecksumAddress` call Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Gabriel Rodríguez Alsina <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: David Albela Pérez <[email protected]> Co-authored-by: lukasschor <[email protected]> Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: francovenica <[email protected]>
fernandomg
added a commit
that referenced
this issue
Mar 18, 2020
* v1.7.3 (#611) * Fix #597: USD value not load (#609) * Converts all the addresses to checksum values * Fix for empty address * fix the order of transactions, change updateSafe to upgradeSafe to avoid naming confusion with the updateSafe action (#610) * Fix #596: Notification when safe is already updated (#599) * Fix notification of update if the safe is already updated * Makes the notification clickable Displays the notification for owners only * Identify upgrade tx * Add red badge to Settings tab * Fixs Padding Removes the red dot if the user is not an owner Co-authored-by: Fernando <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]> * Update package.json (#612) * Add public url to prod webpack config (#615) * add public url to prod webpack config * modify travis/webpack config to add public url * add slash * cherry pick new travis yml merge commit (#620) * V1.7.5 release (#641) * use hash history * update package json * BUG: App index.html cached on production (#642) * remove caching for webapp index.html * keep --delete flag Co-authored-by: Mikhail Mikheev <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustin Pane <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Title/Description
Environment
Steps to reproduce
Expected result
USD value loads
Obtained result
Console says:
The text was updated successfully, but these errors were encountered: