Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Storage Access to be 4337 Compatible #132

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

nlordell
Copy link
Collaborator

@nlordell nlordell commented Nov 8, 2023

This PR changes the manager storage to use the account in the inner most mapping. This allows the Manager to be used with 4337 during signature validation. Note that tests continue to pass.

I also noticed that most storage is public with an addition direct accessor function. This generates additional code (for example, it generates both a enabledPlugins(address,address) function and a getPluginInfo(address,address) function unnecessarily). I think we should either generated accessor methods, or hand-written methods, but definitely not both. Since it is outside of the scope of this PR, I created a separate issue #130 to track this. The reason it is worth mentioning here is that this effectively changes the Manager interface to be slightly different - the order of parameters in the generated accessors for the public mapping has changed, but the hand-written function accessors has not (hence, the Manager still implements ISafeProtocolManager correctly).

Related to #125, #127
Supersedes #128

Copy link

github-actions bot commented Nov 8, 2023

Pull Request Test Coverage Report for Build 6800227554

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6691897064: 0.0%
Covered Lines: 227
Relevant Lines: 227

💛 - Coveralls

@nlordell nlordell added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 71dff1d Nov 9, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants