You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
May storage fields are marked with public. This makes the Solidity compiler generate functions for accessing them. In principle, there is no issue with this. However, many of these storage values have hand-written accessors as well, which means that double code which is doing the same thing is being generated. For example:
May storage fields are marked with
public
. This makes the Solidity compiler generate functions for accessing them. In principle, there is no issue with this. However, many of these storage values have hand-written accessors as well, which means that double code which is doing the same thing is being generated. For example:https://github.com/safe-global/safe-core-protocol/blob/0f3ee326009709a705eb560712bad070b52d8890/contracts/SafeProtocolManager.sol#L29
https://github.com/safe-global/safe-core-protocol/blob/0f3ee326009709a705eb560712bad070b52d8890/contracts/SafeProtocolManager.sol#L231-L233
This generates both
enabledPlugins(address,address)
andgetPluginInfo(address,address)
which do the exact same thing.We should choose one or the other, but not both.
The text was updated successfully, but these errors were encountered: