Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] modify property in sendNotification API #694 #695

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[Fix] modify property in sendNotification API #694 #695

merged 1 commit into from
Feb 28, 2023

Conversation

mike2ox
Copy link
Contributor

@mike2ox mike2ox commented Feb 28, 2023

๐Ÿ“Œ ๊ฐœ์š”

  • ์•Œ๋ฆผ ๋ฉ”์ผ ์ „์†ก ๊ด€๋ จ API ์„ค์ • ๋ณ€๊ฒฝ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • isMail์— ๋“ค์–ด๊ฐ€๋Š” ๊ฐ’์„ ์ •์ƒ์ ์œผ๋กœ ์ˆ˜์ •

@mike2ox mike2ox requested a review from a team as a code owner February 28, 2023 02:21
@mike2ox mike2ox self-assigned this Feb 28, 2023
@mike2ox mike2ox requested review from raehy19 and Wilbur0306 and removed request for a team February 28, 2023 02:21
@mike2ox mike2ox linked an issue Feb 28, 2023 that may be closed by this pull request
[Bug] ํ”ผ๋“œ๋ฐฑ ์ƒํƒœ ๋ณ€๊ฒฝ ์—ฌ๋ถ€๋ฅผ ์•Œ๋ ค์ฃผ๋Š” ์„ค์ • ์˜ค๋ฅ˜ #694
Closed
@mike2ox mike2ox requested a review from 42sungwook February 28, 2023 02:21
@mike2ox mike2ox added bug Something isn't working admin ๊ด€๋ฆฌ์ž ํŽ˜์ด์ง€์—์„œ ๋ฐœ์ƒํ•œ issue labels Feb 28, 2023
raehy19
raehy19 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

Wilbur0306
Wilbur0306 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me .

@mike2ox mike2ox merged commit 7686a9b into main Feb 28, 2023
@mike2ox mike2ox deleted the fix/feedback-status-reverse-behavior-#694 branch February 28, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wilbur0306 Wilbur0306 Wilbur0306 approved these changes

@raehy19 raehy19 raehy19 approved these changes

@42sungwook 42sungwook Awaiting requested review from 42sungwook 42sungwook was automatically assigned from 42organization/fe_2nd

Assignees

@mike2ox mike2ox

Labels
admin ๊ด€๋ฆฌ์ž ํŽ˜์ด์ง€์—์„œ ๋ฐœ์ƒํ•œ issue bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@mike2ox @raehy19 @Wilbur0306