Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 피드백 상태 변경 여부를 알려주는 설정 오류 #694

Closed
mike2ox opened this issue Feb 28, 2023 · 0 comments · Fixed by #695
Closed

[Bug] 피드백 상태 변경 여부를 알려주는 설정 오류 #694

mike2ox opened this issue Feb 28, 2023 · 0 comments · Fixed by #695
Assignees
@mike2ox
Labels
bug Something isn't working

Comments

@mike2ox
Copy link
Contributor

mike2ox commented Feb 28, 2023

Desc

Reproduce

  1. 0af4662 위치에서 재현 가능
  2. npm i && npm run dev 실행
  3. 피드백 페이지에서 특정 피드백의 상태를 변경
  4. 알림을 보낼지를 물어보는 모달 질의에 반대로 피드백 메일 알림이 전송됨

Wanted

Bug img / video

Etc

  • 해당 문제는 FE쪽 알림 등록 API 옵션이 반대로 설정되있어서 발생한 문제였음
@mike2ox mike2ox added the bug Something isn't working label Feb 28, 2023
@mike2ox mike2ox self-assigned this Feb 28, 2023
mike2ox added a commit that referenced this issue Feb 28, 2023
@mike2ox
[Fix] modify property in sendNotification API #694
56934c0
@mike2ox mike2ox linked a pull request Feb 28, 2023 that will close this issue
[Fix] modify property in sendNotification API #694 #695
Merged
mike2ox added a commit that referenced this issue Feb 28, 2023
@mike2ox
[Fix] modify property in sendNotification API #694
7686a9b
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🍌 Version 2 - Frontend Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike2ox mike2ox

Labels
bug Something isn't working
Projects
No open projects
🍌 Version 2 - Frontend
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] modify property in sendNotification API #694 42organization/42gg.client
1 participant
@mike2ox