#135 Enum to same enum conversions #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing a conversion from an enum to the same enum, the AnyToEnumConverter is triggered, which performs a full cycle conversion, using the toString() method of source and the valueOf() of the target enum. When the source enum is the same as the target enum and the source enum has an overridden toString() method, this fails because the value can not be mapped to the enum. Instead, the AnyToEnumConverter now checks whether the source is of the same enum class as the target. If this is the case, the conversion task is skipped and the source is returned literally.
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=========================================
Coverage 93.27% 93.28%
- Complexity 844 845 +1
=========================================
Files 87 87
Lines 1784 1786 +2
Branches 174 175 +1
=========================================
+ Hits 1664 1666 +2
Misses 72 72
Partials 48 48
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a conversion from an enum to the same enum, the
AnyToEnumConverter is triggered, which performs a full cycle conversion,
using the toString() method of source and the valueOf() of the target
enum.
When the source enum is the same as the target enum and the source enum
has an overridden toString() method, this fails because the value can
not be mapped to the enum.
Instead, the AnyToEnumConverter now checks whether the source is of the
same enum class as the target. If this is the case, the conversion task
is skipped and the source is returned literally.