AnyToEnumConverter also triggers on enum > enum mapping

[robert-bor]

Problem

When mapping an enum to an enum of the same class, the AnyToEnumConverter is found as a suitable converter.

When AnyToEnumConverter.doConvert kicks in for converting an enum to its own instance, it takes the toString() value of the enum and then applies that value to a valueOf.

When the enum class has a toString method, this conversion will fail.

Diagnosis

See:

    @Override
    protected Enum<?> doConvert(Object source, Class<? extends Enum<?>> targetClass) {
        if (source == null) {
            return null;
        }
        String sourceText = source.toString();
        if (isNotEmpty(sourceText)) {
            return valueOf(targetClass, sourceText);
        }
        return null;
    }

The doConvert always does the conversion, even if both sides are of the same class type.

Suggestion solution

Make sure the source class is checked against the targetClass. When they are the same immediately return the source and abandon the conversion process.