Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install_script.sh #93

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update install_script.sh #93

merged 2 commits into from
Dec 7, 2023

Conversation

jowodo
Copy link
Contributor

@jowodo jowodo commented Dec 7, 2023

PR #88 was incomplete. I'm very sorry.
I changed two things in install_script.sh:

  1. shift was increase to shift 2 as otherwise the script would hang indefinitely in the case statement.
  2. The check for model_angelo now considers $ENVNAME

jowodo added 2 commits December 7, 2023 15:13
@jowodo
Update install_script.sh
2170515 
previous PR was uncomplete
@jowodo
Update install_script.sh
59c1bc3 
change model_angelo to $ENVNAME in error messages
@jamaliki jamaliki self-requested a review December 7, 2023 21:30
jamaliki
jamaliki approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@jamaliki jamaliki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@jamaliki jamaliki merged commit d4ecc96 into 3dem:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamaliki jamaliki jamaliki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jowodo @jamaliki