Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's "source" not "bash" the install script #4

Closed
biochem-fan opened this issue Oct 5, 2022 · 5 comments
Closed

Let's "source" not "bash" the install script #4

biochem-fan opened this issue Oct 5, 2022 · 5 comments

Comments

@biochem-fan
Copy link
Member

biochem-fan commented Oct 5, 2022

In our cluster, we don't put source /home1/software/packages/miniconda3/etc/profile.d/conda.sh in ~/.bashrc to avoid conflicts.

In this case,

source /home1/software/packages/miniconda3/etc/profile.d/conda.sh
bash install_script.sh --download-weights

does not work because we "Can't execute conda activate from bash script".

conda activate model-angelo silently failed and installed Torch etc into the base environment. I didn't notice the issue until pip failed.

source install_script.sh --download-weights

did the trick.

(The messed up base environment was rolled back by conda install --revision X as explained here.)

@jamaliki
Copy link
Collaborator

jamaliki commented Oct 5, 2022

That makes sense to me, I will change the readme.

Thank you, Takanori!

@jamaliki
Copy link
Collaborator

jamaliki commented Oct 5, 2022

Fixed

@jamaliki jamaliki closed this as completed Oct 5, 2022
@biochem-fan
Copy link
Member Author

Thank you very much for your quick fix.

@biochem-fan
Copy link
Member Author

Hi, you missed the second occurrence of bash install_script.sh (for the cluster install).

@jamaliki
Copy link
Collaborator

jamaliki commented Oct 5, 2022

Oh thanks!

jamaliki added a commit that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants