Support pulling from private git repos #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test this workflow with the procedure in https://github.com/utoronto-2i2c/jupyterhub-deploy/#pulling-from-private-github-repos-with-nbgitpuller You can test it with this link: https://staging.utoronto.2i2c.cloud/hub/user-redirect/git-pull?repo=https%3A%2F%2Fgithub.com%2Futoronto-2i2c%2Fprivate-test-1&branch=main&urlpath=tree%2Fprivate-test-1%2FREADME.md Fixes 2i2c-org#851
| mountPath: /etc/gitconfig | ||
| stringData: | | ||
| [credential "https://github.com"] | ||
| helper = !git-credential-github-app --app-key-file /etc/github/github-app-private-key.pem --app-id 93515 |
There was a problem hiding this comment.
Was wondering where this app-id comes from, then noticed this in the utoronto old docs: https://github.com/organizations/utoronto-2i2c/settings/apps/utoronto-jupyterhub-private-cloner
Maybe add a comment that app 93515 is in fact the private cloner?
GeorgianaElena
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
This looks good to me! We should also add docs about this! Thanks for taking care of this @yuvipanda
|
@GeorgianaElena added a comment! Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this workflow with the procedure in
https://github.com/utoronto-2i2c/jupyterhub-deploy/#pulling-from-private-github-repos-with-nbgitpuller
You can test it with this link:
https://staging.utoronto.2i2c.cloud/hub/user-redirect/git-pull?repo=https%3A%2F%2Fgithub.com%2Futoronto-2i2c%2Fprivate-test-1&branch=main&urlpath=tree%2Fprivate-test-1%2FREADME.md
Fixes #851