Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nbgitpuller pulling from private repositories #851

Closed
3 of 4 tasks
Tracked by #638
yuvipanda opened this issue Nov 24, 2021 · 1 comment · Fixed by #897
Closed
3 of 4 tasks
Tracked by #638

Support nbgitpuller pulling from private repositories #851

yuvipanda opened this issue Nov 24, 2021 · 1 comment · Fixed by #897
Assignees

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Nov 24, 2021

Description

Being able to pull from private GitHub repositories is a very commonly asked for and used feature of nbgitpuller. This was implemented for University of Toronto (utoronto-2i2c/jupyterhub-deploy#44), and is well used there (I think). To move the UToronto hub to this repo (#638), we should enable this feature generally for whatever hubs that want it.

Value / benefit

Instructors can use private git repos with nbgitpuller. I think this is a blocker for migrating utoronto as well.

Implementation details

https://github.com/yuvipanda/git-credential-helpers is the project used to enable this functionality

Tasks to complete

No response

Updates

No response

@choldgraf
Copy link
Member

In our team meeting today I believe @yuvipanda said he'd like to give this one a shot in this cycle, so we've added it to the sprint board! We also discussed that this pattern should be documented in a blog post or something more discoverable for others, so I've added an item about that to the tasks above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants