Add customizable announcements section #5
Conversation
Add home page info about support platform
Make the ticketing service clickable
Add info about UToronto Support Website
templates/login.html
Outdated
| <div class="info text-center"> | ||
| <br> | ||
| <i class="fa fa-info-circle"></i> | ||
| Use <a href=" {{ custom.support_service.url }}">{{ custom.support_service_name }}</a> to open tickets for support questions. |
There was a problem hiding this comment.
Let's just make the entire HTML here customizable? So it's just we can have a list of announcements here. Not everyone has a suppert link...
There was a problem hiding this comment.
Maybe some custom.help.url and custom.help.text?
Even when not everyone has a "support" link, I would bet everyone has some email address people could/should ping if they have some issue/problem, right?
There was a problem hiding this comment.
I actually thought that we could default to our freshdesk support account? Hmm, but maybe my thinking is not right.
Thinking about it, I believe we concluded to have the hub representative reach out to us and not the regular user
There was a problem hiding this comment.
@GeorgianaElena yeah, i think the situation for each hub is different enough that arbitrary HTML here is nice. In the future, we could also perhaps let hub admins set announcements here via the configurator
There was a problem hiding this comment.
maybe delete this section entirely? (see my comment for the code lines bellow)
There was a problem hiding this comment.
Yep, that is the other option, just go with the ANN section, but I still think it is useful to have a "link place" just below the login button...
GeorgianaElena
force-pushed
the
support
branch
from
2a197dd
to
ea7fea5
Compare
GeorgianaElena
force-pushed
the
support
branch
from
07d2a03
to
633e748
Compare
|
@yuvipanda and @damianavila, made
What do you think? |
|
Note that I noticed that UToronto had two support links:
The one under the login button was added first, so maybe in the meantime it became deprecated? not sure though |
This matches what most of other parts of Jupyter do infromally I think
|
I made a commit that changes the padding values slightly so they are multiples of 4 - that's what I've generally seen used in the Jupyter ecosystem and elsewhere. Hope that's ok :D |
|
Also, this will fail if announcements is not set as a key. Can you make it optional? |
I think you could use something like |
|
Thanks @yuvipanda and @damianavila! Made it optional :D |
Super! Btw, did you test if this is behaving as expected when there is no an ANN key? |
|
Yes! I did a deploy this morning on staging with the changes from my fork and I didn't see any errors in the logs. Also, the homepage didn't look funny or anything. But now I'm doubting a bit, as I was pretty sleepy 😅 |
GeorgianaElena
changed the title
Closes 2i2c-org/infrastructure#877
It makes the sections in purple arrow(support service link) and pink arrow (announcement) customizable by our hubs. This screenshot is from the old UToronto hub.
