Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UToronto hub homepage customization #877

Closed
Tracked by #638
GeorgianaElena opened this issue Dec 7, 2021 · 4 comments · Fixed by 2i2c-org/default-hub-homepage#5 or #900
Closed
Tracked by #638

UToronto hub homepage customization #877

GeorgianaElena opened this issue Dec 7, 2021 · 4 comments · Fixed by 2i2c-org/default-hub-homepage#5 or #900

Comments

@GeorgianaElena
Copy link
Member

The homepage of UofT's hub is built from a repository different than the one used by the pilot hubs. This means that the new hub's homepage will look a little different than it had.

Normally, just a slight change in aspects wouldn't be an issue, but there is information in the old homepage, like the link towards the UToronto support service that we need to provide for the new hub also.

@choldgraf
Copy link
Member

@GeorgianaElena good catch - will this require changing the deployment infrastructure for our CI/CD, or is this more a matter of updating something in the Toronto hub's configuration?

@GeorgianaElena
Copy link
Member Author

@choldgraf, it just be just a matter of special casing this config bit:

'args': [
'clone',
'--',
'https://github.com/2i2c-org/pilot-homepage',
'/srv/repo',

@damianavila
Copy link
Contributor

It should be possible to configure that argument through the hub config as we do with the auth class:

generated_config['jupyterhub']['hub']['config']['JupyterHub'] = {'authenticator_class': 'oauthenticator.auth0.Auth0OAuthenticator'}
generated_config['jupyterhub']['hub']['config']['Auth0OAuthenticator'] = auth_provider.get_client_creds(client, self.spec['auth0']['connection'])

Right?

@yuvipanda
Copy link
Member

Our current template customizations https://github.com/2i2c-org/pilot-homepage are actually just modifications from the utoronto repo - you can see that our pilot-homepage repo is actually forked from that!

We can port the functionality of https://github.com/utoronto-2i2c/homepage/pull/5 into https://github.com/2i2c-org/pilot-homepage, but make it a template variable we can specify? Like we do here: https://github.com/2i2c-org/pilot-homepage/blob/a700295784f54413e84072aa4575529251d9636d/templates/login.html#L26. Should help us specify 'announcements' everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants