Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling, partially closes #46 #47

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Improved error handling, partially closes #46 #47

merged 1 commit into from
Dec 20, 2018

Conversation

VictorKoenders
Copy link
Contributor

I saw #46 was closed 5 min ago but I was already working on it, so if you still want it, here it is!

@VictorKoenders
Copy link
Contributor Author

Failure is my preferred crate for handling errors, for what it's worth.

@17cupsofcoffee
Copy link
Owner

I seem to have a knack for picking up issues about half an hour before you submit a PR 😅 Sorry about that!

I added a couple of these From implementations in my branch, but missed out the SDL2 ones, so I'll still take this PR :) Can just rebase my changes on top of it.

I quite like Failure too, but it seems like its future is in flux a bit since the RFC for fixing the Error trait went through. Probably going to stick with standard Rust error handling for now, at least until things are a bit more clear on that front.

@17cupsofcoffee 17cupsofcoffee merged commit 34091d9 into 17cupsofcoffee:master Dec 20, 2018
@VictorKoenders VictorKoenders deleted the improved_error branch August 5, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants