Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Error trait for TetraError #46

Closed
17cupsofcoffee opened this issue Dec 20, 2018 · 2 comments
Closed

Implement the Error trait for TetraError #46

17cupsofcoffee opened this issue Dec 20, 2018 · 2 comments
Labels
Area: Error Handling Issues relating to error handling. Type: Feature Request Improvements that could be made to the code/documentation.

Comments

@17cupsofcoffee
Copy link
Owner

17cupsofcoffee commented Dec 20, 2018 •
edited
Loading

...and we should also implement From for the inner error types where relevant.
@17cupsofcoffee 17cupsofcoffee added Type: Feature Request Improvements that could be made to the code/documentation. Area: Error Handling Issues relating to error handling. labels Dec 20, 2018
@17cupsofcoffee
Copy link
Owner Author

It might also be a nice idea to let people pass a custom error type as a type parameter on State?

@17cupsofcoffee
Copy link
Owner Author

Done in 0.2. Going to punt on custom error types for now - it wouldn't be a breaking change, but going back on it would.

@VictorKoenders VictorKoenders mentioned this issue Dec 20, 2018
Merged
17cupsofcoffee added a commit that referenced this issue Dec 20, 2018
@17cupsofcoffee
Merge pull request #47 from VictorKoenders/improved_error
34091d9 
Improved error handling, partially closes #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Error Handling Issues relating to error handling. Type: Feature Request Improvements that could be made to the code/documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@17cupsofcoffee