Update handling of application passwords. #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
force-pushed
the
update/730-app-pw-handling
branch
from
3a68903 to
008d6cd
Compare
A URL with the `rest_route` set but empty will show the home page of the site rather than the index of the REST API endpoint. This causes the validation of these requests to fail. By ensuring the request to the REST API index always finishes with a trailing slash, this ensures the site receives the expected JSON response data.
This reverts commit 008d6cd.
peterwilsoncc
force-pushed
the
update/730-app-pw-handling
branch
from
98339a4 to
0660849
Compare
peterwilsoncc
requested review from
a team,
ravinderk and
cadic
and removed request for
a team and
ravinderk
cadic
approved these changes
Sep 13, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Modifies the checking of application passwords to validate the rest request using the an API provided by an external site. As part of this, it includes a fix for getting the REST API URL on sites using plain permalinks.
Closes #730
How to test the Change
Changelog Entry
Credits
Props @peterwilsoncc, @TimothyBJacobs, @cadic
Checklist: