Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic authorisation process fails #1050

Closed
1 task done
weronikasiuda opened this issue Apr 20, 2023 · 2 comments
Closed
1 task done

Automatic authorisation process fails #1050

weronikasiuda opened this issue Apr 20, 2023 · 2 comments
Labels
help wanted resolution:duplicate This issue has already been logged. type:bug Something isn't working.
Milestone

Comments

@weronikasiuda
Copy link

Describe the bug

Hi,

The automatic authorisation process is failing on one of our websites and redirecting to a 404 page on the external site. The issue appeared to be hosting-specific. Having reached out to our hosting provider support, here is their explanation:

Hi there,

We've not actively disallowed the plugin, but I think this issue is likely because the link it goes to does not collect the siteurl from the database, and instead just assumes the core files are in the webroot.

In this case the link should look like this:

https://example.co.uk/wp/wp-admin/authorize-application.php

Instead of this:

https://example/wp-admin/authorize-application.php

They can fix this in their code by using WordPress' get_site_url() function:

https://developer.wordpress.org/reference/functions/get_site_url/)

Steps to Reproduce

  1. Go to "External connection" => "Add new".
  2. Add the external site URL and select "authorise connection".

Screenshots, screen recording, code snippet

No response

Environment information

N/A

WordPress information

N/A

Code of Conduct

  • I agree to follow this project's Code of Conduct
@weronikasiuda weronikasiuda added the type:bug Something isn't working. label Apr 20, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Apr 20, 2023
@jeffpaul jeffpaul added this to the 2.0.0 milestone Apr 20, 2023
@weronikasiuda
Copy link
Author

Hi! Thank you so much for looking into it - do you think this is likely to be resolved soon, i.e. in the next week or so? We rely on this in one of our projects, so if this proves to be more complicated, we will need to reconsider our tools!

@peterwilsoncc peterwilsoncc added the resolution:duplicate This issue has already been logged. label May 25, 2023
@peterwilsoncc
Copy link
Collaborator

A fix for this is included in the upcoming 2.0.0 release, it was fixed in #934

This issue was originally reported in #730, so I'll close this issue off as a duplicate.

@peterwilsoncc peterwilsoncc closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@github-project-automation github-project-automation bot moved this from To Do to Merged in Open Source Practice May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted resolution:duplicate This issue has already been logged. type:bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

3 participants