Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update admin icon #1132

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

zach-adams
Copy link
Contributor

Description of the Change

Closes #1119

Updates the admin SVG icon to have roughly the same width & height so it no long appears squished in the admin menus or in the block editor plugin. The main benefit realized is that it will no longer mildly annoy me whenever I notice it's squished 😉

The SVG has been reworked & simplified to smooth out several issues that appeared when the original was enlarged. It's down to just 2 path elements which reduces file size greatly (8KB to 1.5KB) and it should make it somewhat easier to update in the future.

Applies to:

  • Main admin menu plugin icon
  • Pages/Posts list plugin column icon
  • Block editor plugin icon
  • README (icon at the top, when merged into trunk)

Examples of how it looked before vs with the updated icon:

Before Updated
old-icon
2023-09-06_20-52-3LOLjpfR 2023-09-06_20-53-KP7F9TLm
2023-09-06_20-54-Jz3aw2Ri 2023-09-06_20-54-XzgYtqjI
2023-09-06_20-55-3IA3Vm8h 2023-09-06_20-55-YxvIwLWi
2023-09-06_20-58-twzCj9ad 2023-09-06_20-57-WqLyGegZ

How to test the Change

  1. Install and activate Distributor plugin
  2. Check admin main menu "Distributor" icon is updated & showing correctly
  3. Check that the updated menu icon color matches other admin menu icons including on hover & when it's active while visiting a Distributor setting sub-page (should auto-update to white when active)
  4. Check Posts/Pages list page & verify the Distributor column icon is updated & showing correctly
  5. Open a Post/Page block editor and verify the icon in the Distributor tab in the sidebar page settings is updated & showing correctly

Changelog Entry

Fixed - Admin icon has been updated so it has the same width/height

Credits

Props @zach-adams

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@zach-adams zach-adams requested review from jeffpaul and a team as code owners September 7, 2023 04:08
@jeffpaul jeffpaul removed their request for review September 7, 2023 13:28
@jeffpaul jeffpaul added this to the 2.0.1 milestone Sep 7, 2023
@jeffpaul jeffpaul requested review from a team and ravinderk and removed request for a team September 7, 2023 13:29
@@ -306,7 +306,7 @@ function admin_menu() {
* @since 1.2
*/
function network_admin_menu() {
add_menu_page( 'Distributor', 'Distributor', 'manage_options', 'distributor-settings', __NAMESPACE__ . '\network_settings_screen', 'data:image/svg+xml;base64,<svg width="36" height="39" viewBox="0 0 36 39" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><title>distributor-icon</title><desc>Created using Figma</desc><g id="Canvas" transform="translate(-4024 365)"><g id="distributor-icon"><use xlink:href="#path0_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path1_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path2_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path3_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path4_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path5_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path6_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/></g></g><defs><path id="path0_fill" d="M 7.93814 23.1108C 7.00743 23.1108 6.2915 23.9045 6.2915 24.9362C 6.2915 25.8887 7.00743 26.7617 7.86654 26.7617C 8.94043 28.4284 10.3723 29.7777 12.0189 30.7301C 13.594 31.6032 15.3122 32 16.9588 32C 21.1112 32 25.1204 29.4602 27.125 25.0156C 28.4852 21.9996 28.6284 18.6662 27.6977 15.4915C 26.6954 12.3167 24.6908 9.77696 21.9703 8.26896C 16.3861 5.25298 9.65636 7.79276 6.86425 13.9835L 6.64947 14.3803L 6.72106 14.3803C 6.43469 15.0152 6.21991 15.8883 6.79265 16.2058L 12.7348 18.7455C 12.7348 18.9836 12.6633 19.2218 12.6633 19.4599C 12.6633 22.079 14.5963 24.2219 16.9588 24.2219C 19.3214 24.2219 21.2544 22.079 21.2544 19.4599C 21.2544 16.8407 19.3214 14.6978 16.9588 14.6978C 15.527 14.6978 14.2383 15.4915 13.4508 16.682L 8.58247 14.6184C 9.72795 12.2374 11.5894 10.4119 13.8803 9.53885C 16.2429 8.6658 18.8202 8.82454 21.1112 10.0151C 25.7647 12.5548 27.6977 18.8249 25.4068 23.9838C 24.3329 26.5236 22.3999 28.3491 19.9657 29.3015C 17.6031 30.1745 15.0258 30.0158 12.7348 28.8253C 11.3746 28.111 10.2291 26.9998 9.2984 25.6506C 9.36999 25.4125 9.44158 25.1744 9.44158 24.9362C 9.58477 23.9838 8.79725 23.1108 7.93814 23.1108Z"/><path id="path1_fill" fill-rule="evenodd" d="M 12.0189 30.7301C 10.3723 29.7777 8.94043 28.4284 7.86654 26.7617C 7.00743 26.7617 6.2915 25.8887 6.2915 24.9362C 6.2915 23.9045 7.00743 23.1108 7.93814 23.1108C 8.79725 23.1108 9.58477 23.9838 9.44158 24.9362C 9.44158 25.1744 9.36999 25.4125 9.2984 25.6506C 10.2291 26.9998 11.3746 28.111 12.7348 28.8253C 15.0258 30.0158 17.6031 30.1745 19.9657 29.3015C 22.3999 28.3491 24.3329 26.5236 25.4068 23.9838C 27.6977 18.8249 25.7647 12.5548 21.1112 10.0151C 18.8202 8.82454 16.2429 8.6658 13.8803 9.53885C 11.6765 10.3787 9.87007 12.0999 8.71616 14.3493C 8.67056 14.4382 8.62602 14.5279 8.58247 14.6184L 13.4508 16.682C 14.2383 15.4915 15.527 14.6978 16.9588 14.6978C 19.3214 14.6978 21.2544 16.8407 21.2544 19.4599C 21.2544 22.079 19.3214 24.2219 16.9588 24.2219C 14.5963 24.2219 12.6633 22.079 12.6633 19.4599C 12.6633 19.3408 12.6811 19.2218 12.699 19.1027C 12.7169 18.9837 12.7348 18.8646 12.7348 18.7455L 6.79265 16.2058C 6.30607 15.936 6.38784 15.2653 6.59907 14.6803C 6.61517 14.6357 6.63202 14.5917 6.64942 14.5483C 6.66808 14.5018 6.68738 14.4561 6.70708 14.4115C 6.7117 14.4011 6.7164 14.3906 6.72106 14.3803L 6.64947 14.3803L 6.86425 13.9835C 9.65636 7.79276 16.3861 5.25298 21.9703 8.26896C 24.6908 9.77696 26.6954 12.3167 27.6977 15.4915C 28.6284 18.6662 28.4852 21.9996 27.125 25.0156C 25.1204 29.4602 21.1112 32 16.9588 32C 15.3122 32 13.594 31.6032 12.0189 30.7301ZM 6.59522 13.8502C 9.45298 7.52723 16.3604 4.89819 22.1128 8.00502L 22.1157 8.00658C 24.9091 9.55495 26.9604 12.1596 27.9838 15.4011L 27.9856 15.4071C 28.9262 18.6299 28.7771 22.069 27.3984 25.139C 25.3489 29.6832 21.2376 32.3 16.9588 32.3C 15.2782 32.2981 13.4864 31.8832 11.8734 30.9925L 11.8686 30.9899C 10.2356 30.0431 8.78526 28.6911 7.69859 27.053C 6.71423 26.9497 5.99146 25.9496 5.99146 24.9363C 5.99146 23.7686 6.81335 22.8108 7.93809 22.8108C 8.97878 22.8108 9.89729 23.8392 9.74105 24.9612C 9.73503 25.1811 9.68306 25.3998 9.62679 25.5972C 10.5227 26.8682 11.5891 27.8879 12.8732 28.5591C 15.089 29.7106 17.5773 29.8634 19.859 29.0211C 22.2176 28.0975 24.0888 26.3304 25.1304 23.867L 25.1325 23.8621C 27.3659 18.8327 25.4714 12.7386 20.9701 10.2799C 18.7545 9.12946 16.2668 8.97724 13.9857 9.81974C 11.8668 10.6277 10.1178 12.2847 8.99313 14.4667L 13.3439 16.3109C 14.1882 15.1622 15.4978 14.3978 16.9588 14.3978C 19.5154 14.3978 21.5543 16.7049 21.5543 19.4599C 21.5543 22.2149 19.5154 24.5219 16.9588 24.5219C 14.4022 24.5219 12.3632 22.2149 12.3632 19.4599C 12.364 19.3185 12.3844 19.1772 12.4023 19.0581L 12.405 19.0405C 12.4104 19.0043 12.4156 18.9701 12.42 18.9373L 6.66059 16.4756L 6.64716 16.4682C 6.21685 16.2296 6.11427 15.7881 6.13506 15.3962C 6.14893 15.1659 6.20676 14.9157 6.28365 14.6803L 6.14593 14.6803L 6.59522 13.8502Z"/><path id="path2_fill" d="M 32.1281 10.0168C 32.1281 9.0063 31.3955 8.22899 30.4432 8.22899C 29.4908 8.22899 28.7582 9.0063 28.7582 10.0168C 28.7582 10.9496 29.4908 11.7269 30.3699 11.8046C 32.8607 16.3908 33.0805 22.0651 30.8827 26.8845C 29.0512 30.771 25.9743 33.6471 22.1648 34.9685C 18.3553 36.3677 14.2528 36.0567 10.6631 34.1912C 3.19062 30.3046 0.113724 20.666 3.7767 12.7374C 5.97448 7.9958 10.2968 4.73109 15.1319 3.95378C 15.425 4.34244 15.8645 4.57563 16.3773 4.57563C 17.3297 4.57563 18.0623 3.79832 18.0623 2.78782C 18.0623 1.77731 17.3297 1 16.3773 1C 15.718 1 15.2052 1.38866 14.9121 1.93277C 9.41768 2.78782 4.5093 6.51891 2.01847 11.8824C 0.0404656 16.2353 -0.252573 21.1324 1.21262 25.7185C 2.67781 30.3046 5.75471 33.958 9.78398 36.1345C 12.2015 37.3782 14.7656 38 17.2564 38C 23.5568 38 29.6373 34.2689 32.5677 27.895C 35.0585 22.4538 34.8387 16.0021 31.9816 10.7941C 32.0549 10.5609 32.1281 10.3277 32.1281 10.0168Z"/><path id="path3_fill" fill-rule="evenodd" d="M 2.01847 11.8824C 4.5093 6.51891 9.41768 2.78782 14.9121 1.93277C 15.2052 1.38866 15.718 1 16.3773 1C 17.3297 1 18.0623 1.77731 18.0623 2.78782C 18.0623 3.79832 17.3297 4.57563 16.3773 4.57563C 15.8645 4.57563 15.425 4.34244 15.1319 3.95378C 10.2968 4.73109 5.97448 7.9958 3.7767 12.7374C 0.113724 20.666 3.19062 30.3046 10.6631 34.1912C 14.2528 36.0567 18.3553 36.3677 22.1648 34.9685C 25.9743 33.6471 29.0512 30.771 30.8827 26.8845C 33.0805 22.0651 32.8607 16.3908 30.3699 11.8046C 29.4908 11.7269 28.7582 10.9496 28.7582 10.0168C 28.7582 9.0063 29.4908 8.22899 30.4432 8.22899C 31.3955 8.22899 32.1281 9.0063 32.1281 10.0168C 32.1281 10.3277 32.0549 10.5609 31.9816 10.7941C 34.8387 16.0021 35.0585 22.4538 32.5677 27.895C 29.6373 34.2689 23.5568 38 17.2564 38C 14.7656 38 12.2015 37.3782 9.78398 36.1345C 5.75471 33.958 2.67781 30.3046 1.21262 25.7185C -0.252573 21.1324 0.0404656 16.2353 2.01847 11.8824ZM 32.3055 10.7616C 32.3671 10.5546 32.4253 10.3129 32.4282 10.0168C 32.4282 8.85762 31.5777 7.929 30.4432 7.929C 29.3086 7.929 28.4582 8.85762 28.4582 10.0168C 28.4582 11.046 29.22 11.9138 30.1782 12.0817C 32.556 16.5609 32.747 22.072 30.6106 26.7582C 28.8103 30.5776 25.7926 33.3926 22.0665 34.6851L 22.0614 34.6869C 18.3336 36.0561 14.3187 35.7529 10.8016 33.925C 3.48056 30.1173 0.448866 20.6562 4.049 12.8634C 6.18072 8.26446 10.3461 5.08682 15.0118 4.27801C 15.3555 4.65311 15.8334 4.87564 16.3774 4.87564C 17.5119 4.87564 18.3623 3.94702 18.3623 2.78783C 18.3623 1.62863 17.5119 0.700012 16.3774 0.700012C 15.6422 0.700012 15.0697 1.10548 14.7243 1.65905C 9.18401 2.57177 4.25612 6.35189 1.74641 11.756L 1.74538 11.7583C -0.250678 16.1631 -0.55021 21.1697 0.926879 25.8098C 2.41557 30.4695 5.54358 34.1849 9.64143 36.3984L 9.64677 36.4012C 12.0969 37.6593 14.7301 38.2979 17.2565 38.3C 23.676 38.3 29.8618 34.4989 32.8403 28.0203C 35.3524 22.5326 35.1508 16.0338 32.3055 10.7616Z"/><path id="path4_fill" d="M 19.2915 2.5C 19.2915 3.88071 18.1722 5 16.7915 5C 15.4108 5 14.2915 3.88071 14.2915 2.5C 14.2915 1.11929 15.4108 0 16.7915 0C 18.1722 0 19.2915 1.11929 19.2915 2.5Z"/><path id="path5_fill" d="M 33.2915 10.5C 33.2915 11.8807 32.1722 13 30.7915 13C 29.4108 13 28.2915 11.8807 28.2915 10.5C 28.2915 9.11929 29.4108 8 30.7915 8C 32.1722 8 33.2915 9.11929 33.2915 10.5Z"/><path id="path6_fill" d="M 10.2915 25.5C 10.2915 26.8807 9.17222 28 7.7915 28C 6.41079 28 5.2915 26.8807 5.2915 25.5C 5.2915 24.1193 6.41079 23 7.7915 23C 9.17222 23 10.2915 24.1193 10.2915 25.5Z"/></defs></svg>' );
add_menu_page( 'Distributor', 'Distributor', 'manage_options', 'distributor-settings', __NAMESPACE__ . '\network_settings_screen', 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHN0eWxlPSJmaWxsLXJ1bGU6ZXZlbm9kZDtjbGlwLXJ1bGU6ZXZlbm9kZDtzdHJva2UtbGluZWpvaW46cm91bmQ7c3Ryb2tlLW1pdGVybGltaXQ6MiIgdmlld0JveD0iMTMuNCA4LjggNTczLjIgNTczLjIiPgogIDxwYXRoIGZpbGw9IiNhN2FhYWQiIGQ9Ik0xOTUuMTEzIDQxMS4wMzNjNDUuODM1IDQ2LjY5MiAxMTkuMTI0IDU4LjQ4OCAxNzguMzg3IDI0LjI3MyA3MC4yNjItNDAuNTY2IDk0LjM3MS0xMzAuNTQ0IDUzLjgwNi0yMDAuODA2LTQwLjU2Ni03MC4yNjItMTMwLjU0NC05NC4zNzEtMjAwLjgwNi01My44MDYtMTkuODczIDExLjQ3NC0zNi4wNTUgMjYuODk5LTQ4LjEyNCA0NC43MTVsNjQuNzIyIDMzLjE4NmMyMi4yMDEtMjUuNTkzIDU5Ljc5Ni0zMy43ODIgOTEuMjc5LTE3LjYzOSAzNy4wMDIgMTguOTczIDUxLjY0IDY0LjQxOCAzMi42NjcgMTAxLjQyMS0xOC45NzMgMzcuMDAyLTY0LjQxOCA1MS42NC0xMDEuNDIxIDMyLjY2Ny0zMS40ODMtMTYuMTQzLTQ2Ljc3Ni01MS40NS0zOC45NTEtODQuNDE1bC04MS43MDItNDEuODkyYy04LjgzOC00LjUzMi0xMi4zMzUtMTUuMzY3LTcuODE0LTI0LjIxMSAxNS41MTQtMzAuMzQ2IDM5LjY1OC01Ni43MTUgNzEuMzQ0LTc1LjAwOSA4Ny40NjktNTAuNSAxOTkuNDgyLTIwLjQ4NiAyNDkuOTgzIDY2Ljk4MyA1MC41IDg3LjQ2OSAyMC40ODYgMTk5LjQ4Mi02Ni45ODMgMjQ5Ljk4My03NS4yMzUgNDMuNDM3LTE2OC42MyAyNy4zMDctMjI1LjQxOS0zMy43MTctMTcuODA5IDMuNzc4LTM2Ljc5Ny00LjA1NS00Ni4zODctMjAuNjY2LTExLjkyMi0yMC42NDgtNC44MzctNDcuMDkxIDE1LjgxMi01OS4wMTIgMjAuNjQ4LTExLjkyMiA0Ny4wOTEtNC44MzYgNTkuMDEyIDE1LjgxMiA3Ljc3IDEzLjQ1OCA3LjQ2NiAyOS4zNzcuNTk1IDQyLjEzM1oiLz4KICA8cGF0aCBmaWxsPSIjYTdhYWFkIiBkPSJNMjYyLjIzNyA3Mi45ODVDMTQ4LjggOTEuMTAxIDYyIDE4OS40OTQgNjIgMzA4YzAgMTMxLjM1NiAxMDYuNjQ0IDIzOCAyMzggMjM4czIzOC0xMDYuNjQ0IDIzOC0yMzhjMC0zNC4wNTktNy4xNjgtNjYuNDU4LTIwLjA4LTk1Ljc2Ni0xNS4xMjEuOTktMzAuMzIzLTYuMDE0LTM5LjEzNy0xOS42MjYtMTIuOTU5LTIwLjAxNC03LjIzMS00Ni43ODMgMTIuNzgzLTU5Ljc0MiAyMC4wMTQtMTIuOTU4IDQ2Ljc4My03LjIzMSA1OS43NDIgMTIuNzgzIDEwLjA5NSAxNS41OTIgOC44NDkgMzUuMjg0LTEuNjU3IDQ5LjM1MkM1NjUuMjg4IDIyOS40NjEgNTc0IDI2Ny43MjEgNTc0IDMwOGMwIDE1MS4yMjUtMTIyLjc3NSAyNzQtMjc0IDI3NFMyNiA0NTkuMjI1IDI2IDMwOEMyNiAxNzAuNTM5IDEyNy40NDMgNTYuNTg0IDI1OS40ODcgMzYuOTggMjY1LjU5NCAyMC41MzMgMjgxLjQzOCA4LjggMzAwIDguOGMyMy44NDMgMCA0My4yIDE5LjM1NyA0My4yIDQzLjIgMCAyMy44NDMtMTkuMzU3IDQzLjItNDMuMiA0My4yLTE2LjIyOSAwLTMwLjM4LTguOTY4LTM3Ljc2My0yMi4yMTVaIi8+Cjwvc3ZnPgo=' );
Copy link
Contributor

@ravinderk ravinderk Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zach-adams can we create a separate file and function to get the data image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll take a look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravinderk Would moving these data URL strings to a function in utils.php called something like "get_admin_icon" work alright? That way it could be simplified both here and in the 'external-connection-cpt.php' file to:

Suggested change
add_menu_page( 'Distributor', 'Distributor', 'manage_options', 'distributor-settings', __NAMESPACE__ . '\network_settings_screen', 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHN0eWxlPSJmaWxsLXJ1bGU6ZXZlbm9kZDtjbGlwLXJ1bGU6ZXZlbm9kZDtzdHJva2UtbGluZWpvaW46cm91bmQ7c3Ryb2tlLW1pdGVybGltaXQ6MiIgdmlld0JveD0iMTMuNCA4LjggNTczLjIgNTczLjIiPgogIDxwYXRoIGZpbGw9IiNhN2FhYWQiIGQ9Ik0xOTUuMTEzIDQxMS4wMzNjNDUuODM1IDQ2LjY5MiAxMTkuMTI0IDU4LjQ4OCAxNzguMzg3IDI0LjI3MyA3MC4yNjItNDAuNTY2IDk0LjM3MS0xMzAuNTQ0IDUzLjgwNi0yMDAuODA2LTQwLjU2Ni03MC4yNjItMTMwLjU0NC05NC4zNzEtMjAwLjgwNi01My44MDYtMTkuODczIDExLjQ3NC0zNi4wNTUgMjYuODk5LTQ4LjEyNCA0NC43MTVsNjQuNzIyIDMzLjE4NmMyMi4yMDEtMjUuNTkzIDU5Ljc5Ni0zMy43ODIgOTEuMjc5LTE3LjYzOSAzNy4wMDIgMTguOTczIDUxLjY0IDY0LjQxOCAzMi42NjcgMTAxLjQyMS0xOC45NzMgMzcuMDAyLTY0LjQxOCA1MS42NC0xMDEuNDIxIDMyLjY2Ny0zMS40ODMtMTYuMTQzLTQ2Ljc3Ni01MS40NS0zOC45NTEtODQuNDE1bC04MS43MDItNDEuODkyYy04LjgzOC00LjUzMi0xMi4zMzUtMTUuMzY3LTcuODE0LTI0LjIxMSAxNS41MTQtMzAuMzQ2IDM5LjY1OC01Ni43MTUgNzEuMzQ0LTc1LjAwOSA4Ny40NjktNTAuNSAxOTkuNDgyLTIwLjQ4NiAyNDkuOTgzIDY2Ljk4MyA1MC41IDg3LjQ2OSAyMC40ODYgMTk5LjQ4Mi02Ni45ODMgMjQ5Ljk4My03NS4yMzUgNDMuNDM3LTE2OC42MyAyNy4zMDctMjI1LjQxOS0zMy43MTctMTcuODA5IDMuNzc4LTM2Ljc5Ny00LjA1NS00Ni4zODctMjAuNjY2LTExLjkyMi0yMC42NDgtNC44MzctNDcuMDkxIDE1LjgxMi01OS4wMTIgMjAuNjQ4LTExLjkyMiA0Ny4wOTEtNC44MzYgNTkuMDEyIDE1LjgxMiA3Ljc3IDEzLjQ1OCA3LjQ2NiAyOS4zNzcuNTk1IDQyLjEzM1oiLz4KICA8cGF0aCBmaWxsPSIjYTdhYWFkIiBkPSJNMjYyLjIzNyA3Mi45ODVDMTQ4LjggOTEuMTAxIDYyIDE4OS40OTQgNjIgMzA4YzAgMTMxLjM1NiAxMDYuNjQ0IDIzOCAyMzggMjM4czIzOC0xMDYuNjQ0IDIzOC0yMzhjMC0zNC4wNTktNy4xNjgtNjYuNDU4LTIwLjA4LTk1Ljc2Ni0xNS4xMjEuOTktMzAuMzIzLTYuMDE0LTM5LjEzNy0xOS42MjYtMTIuOTU5LTIwLjAxNC03LjIzMS00Ni43ODMgMTIuNzgzLTU5Ljc0MiAyMC4wMTQtMTIuOTU4IDQ2Ljc4My03LjIzMSA1OS43NDIgMTIuNzgzIDEwLjA5NSAxNS41OTIgOC44NDkgMzUuMjg0LTEuNjU3IDQ5LjM1MkM1NjUuMjg4IDIyOS40NjEgNTc0IDI2Ny43MjEgNTc0IDMwOGMwIDE1MS4yMjUtMTIyLjc3NSAyNzQtMjc0IDI3NFMyNiA0NTkuMjI1IDI2IDMwOEMyNiAxNzAuNTM5IDEyNy40NDMgNTYuNTg0IDI1OS40ODcgMzYuOTggMjY1LjU5NCAyMC41MzMgMjgxLjQzOCA4LjggMzAwIDguOGMyMy44NDMgMCA0My4yIDE5LjM1NyA0My4yIDQzLjIgMCAyMy44NDMtMTkuMzU3IDQzLjItNDMuMiA0My4yLTE2LjIyOSAwLTMwLjM4LTguOTY4LTM3Ljc2My0yMi4yMTVaIi8+Cjwvc3ZnPgo=' );
add_menu_page( 'Distributor', 'Distributor', 'manage_options', 'distributor-settings', __NAMESPACE__ . '\network_settings_screen', Utils\get_admin_icon() );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zach-adams Make sense.

@@ -662,7 +662,7 @@ function add_menu_item() {
apply_filters( 'dt_capabilities', 'manage_options' ),
'distributor',
__NAMESPACE__ . '\dashboard',
'data:image/svg+xml;base64,<svg width="36" height="39" viewBox="0 0 36 39" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><title>distributor-icon</title><desc>Created using Figma</desc><g id="Canvas" transform="translate(-4024 365)"><g id="distributor-icon"><use xlink:href="#path0_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path1_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path2_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path3_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path4_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path5_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/><use xlink:href="#path6_fill" transform="translate(4024.71 -365)" fill="#A0A5AA"/></g></g><defs><path id="path0_fill" d="M 7.93814 23.1108C 7.00743 23.1108 6.2915 23.9045 6.2915 24.9362C 6.2915 25.8887 7.00743 26.7617 7.86654 26.7617C 8.94043 28.4284 10.3723 29.7777 12.0189 30.7301C 13.594 31.6032 15.3122 32 16.9588 32C 21.1112 32 25.1204 29.4602 27.125 25.0156C 28.4852 21.9996 28.6284 18.6662 27.6977 15.4915C 26.6954 12.3167 24.6908 9.77696 21.9703 8.26896C 16.3861 5.25298 9.65636 7.79276 6.86425 13.9835L 6.64947 14.3803L 6.72106 14.3803C 6.43469 15.0152 6.21991 15.8883 6.79265 16.2058L 12.7348 18.7455C 12.7348 18.9836 12.6633 19.2218 12.6633 19.4599C 12.6633 22.079 14.5963 24.2219 16.9588 24.2219C 19.3214 24.2219 21.2544 22.079 21.2544 19.4599C 21.2544 16.8407 19.3214 14.6978 16.9588 14.6978C 15.527 14.6978 14.2383 15.4915 13.4508 16.682L 8.58247 14.6184C 9.72795 12.2374 11.5894 10.4119 13.8803 9.53885C 16.2429 8.6658 18.8202 8.82454 21.1112 10.0151C 25.7647 12.5548 27.6977 18.8249 25.4068 23.9838C 24.3329 26.5236 22.3999 28.3491 19.9657 29.3015C 17.6031 30.1745 15.0258 30.0158 12.7348 28.8253C 11.3746 28.111 10.2291 26.9998 9.2984 25.6506C 9.36999 25.4125 9.44158 25.1744 9.44158 24.9362C 9.58477 23.9838 8.79725 23.1108 7.93814 23.1108Z"/><path id="path1_fill" fill-rule="evenodd" d="M 12.0189 30.7301C 10.3723 29.7777 8.94043 28.4284 7.86654 26.7617C 7.00743 26.7617 6.2915 25.8887 6.2915 24.9362C 6.2915 23.9045 7.00743 23.1108 7.93814 23.1108C 8.79725 23.1108 9.58477 23.9838 9.44158 24.9362C 9.44158 25.1744 9.36999 25.4125 9.2984 25.6506C 10.2291 26.9998 11.3746 28.111 12.7348 28.8253C 15.0258 30.0158 17.6031 30.1745 19.9657 29.3015C 22.3999 28.3491 24.3329 26.5236 25.4068 23.9838C 27.6977 18.8249 25.7647 12.5548 21.1112 10.0151C 18.8202 8.82454 16.2429 8.6658 13.8803 9.53885C 11.6765 10.3787 9.87007 12.0999 8.71616 14.3493C 8.67056 14.4382 8.62602 14.5279 8.58247 14.6184L 13.4508 16.682C 14.2383 15.4915 15.527 14.6978 16.9588 14.6978C 19.3214 14.6978 21.2544 16.8407 21.2544 19.4599C 21.2544 22.079 19.3214 24.2219 16.9588 24.2219C 14.5963 24.2219 12.6633 22.079 12.6633 19.4599C 12.6633 19.3408 12.6811 19.2218 12.699 19.1027C 12.7169 18.9837 12.7348 18.8646 12.7348 18.7455L 6.79265 16.2058C 6.30607 15.936 6.38784 15.2653 6.59907 14.6803C 6.61517 14.6357 6.63202 14.5917 6.64942 14.5483C 6.66808 14.5018 6.68738 14.4561 6.70708 14.4115C 6.7117 14.4011 6.7164 14.3906 6.72106 14.3803L 6.64947 14.3803L 6.86425 13.9835C 9.65636 7.79276 16.3861 5.25298 21.9703 8.26896C 24.6908 9.77696 26.6954 12.3167 27.6977 15.4915C 28.6284 18.6662 28.4852 21.9996 27.125 25.0156C 25.1204 29.4602 21.1112 32 16.9588 32C 15.3122 32 13.594 31.6032 12.0189 30.7301ZM 6.59522 13.8502C 9.45298 7.52723 16.3604 4.89819 22.1128 8.00502L 22.1157 8.00658C 24.9091 9.55495 26.9604 12.1596 27.9838 15.4011L 27.9856 15.4071C 28.9262 18.6299 28.7771 22.069 27.3984 25.139C 25.3489 29.6832 21.2376 32.3 16.9588 32.3C 15.2782 32.2981 13.4864 31.8832 11.8734 30.9925L 11.8686 30.9899C 10.2356 30.0431 8.78526 28.6911 7.69859 27.053C 6.71423 26.9497 5.99146 25.9496 5.99146 24.9363C 5.99146 23.7686 6.81335 22.8108 7.93809 22.8108C 8.97878 22.8108 9.89729 23.8392 9.74105 24.9612C 9.73503 25.1811 9.68306 25.3998 9.62679 25.5972C 10.5227 26.8682 11.5891 27.8879 12.8732 28.5591C 15.089 29.7106 17.5773 29.8634 19.859 29.0211C 22.2176 28.0975 24.0888 26.3304 25.1304 23.867L 25.1325 23.8621C 27.3659 18.8327 25.4714 12.7386 20.9701 10.2799C 18.7545 9.12946 16.2668 8.97724 13.9857 9.81974C 11.8668 10.6277 10.1178 12.2847 8.99313 14.4667L 13.3439 16.3109C 14.1882 15.1622 15.4978 14.3978 16.9588 14.3978C 19.5154 14.3978 21.5543 16.7049 21.5543 19.4599C 21.5543 22.2149 19.5154 24.5219 16.9588 24.5219C 14.4022 24.5219 12.3632 22.2149 12.3632 19.4599C 12.364 19.3185 12.3844 19.1772 12.4023 19.0581L 12.405 19.0405C 12.4104 19.0043 12.4156 18.9701 12.42 18.9373L 6.66059 16.4756L 6.64716 16.4682C 6.21685 16.2296 6.11427 15.7881 6.13506 15.3962C 6.14893 15.1659 6.20676 14.9157 6.28365 14.6803L 6.14593 14.6803L 6.59522 13.8502Z"/><path id="path2_fill" d="M 32.1281 10.0168C 32.1281 9.0063 31.3955 8.22899 30.4432 8.22899C 29.4908 8.22899 28.7582 9.0063 28.7582 10.0168C 28.7582 10.9496 29.4908 11.7269 30.3699 11.8046C 32.8607 16.3908 33.0805 22.0651 30.8827 26.8845C 29.0512 30.771 25.9743 33.6471 22.1648 34.9685C 18.3553 36.3677 14.2528 36.0567 10.6631 34.1912C 3.19062 30.3046 0.113724 20.666 3.7767 12.7374C 5.97448 7.9958 10.2968 4.73109 15.1319 3.95378C 15.425 4.34244 15.8645 4.57563 16.3773 4.57563C 17.3297 4.57563 18.0623 3.79832 18.0623 2.78782C 18.0623 1.77731 17.3297 1 16.3773 1C 15.718 1 15.2052 1.38866 14.9121 1.93277C 9.41768 2.78782 4.5093 6.51891 2.01847 11.8824C 0.0404656 16.2353 -0.252573 21.1324 1.21262 25.7185C 2.67781 30.3046 5.75471 33.958 9.78398 36.1345C 12.2015 37.3782 14.7656 38 17.2564 38C 23.5568 38 29.6373 34.2689 32.5677 27.895C 35.0585 22.4538 34.8387 16.0021 31.9816 10.7941C 32.0549 10.5609 32.1281 10.3277 32.1281 10.0168Z"/><path id="path3_fill" fill-rule="evenodd" d="M 2.01847 11.8824C 4.5093 6.51891 9.41768 2.78782 14.9121 1.93277C 15.2052 1.38866 15.718 1 16.3773 1C 17.3297 1 18.0623 1.77731 18.0623 2.78782C 18.0623 3.79832 17.3297 4.57563 16.3773 4.57563C 15.8645 4.57563 15.425 4.34244 15.1319 3.95378C 10.2968 4.73109 5.97448 7.9958 3.7767 12.7374C 0.113724 20.666 3.19062 30.3046 10.6631 34.1912C 14.2528 36.0567 18.3553 36.3677 22.1648 34.9685C 25.9743 33.6471 29.0512 30.771 30.8827 26.8845C 33.0805 22.0651 32.8607 16.3908 30.3699 11.8046C 29.4908 11.7269 28.7582 10.9496 28.7582 10.0168C 28.7582 9.0063 29.4908 8.22899 30.4432 8.22899C 31.3955 8.22899 32.1281 9.0063 32.1281 10.0168C 32.1281 10.3277 32.0549 10.5609 31.9816 10.7941C 34.8387 16.0021 35.0585 22.4538 32.5677 27.895C 29.6373 34.2689 23.5568 38 17.2564 38C 14.7656 38 12.2015 37.3782 9.78398 36.1345C 5.75471 33.958 2.67781 30.3046 1.21262 25.7185C -0.252573 21.1324 0.0404656 16.2353 2.01847 11.8824ZM 32.3055 10.7616C 32.3671 10.5546 32.4253 10.3129 32.4282 10.0168C 32.4282 8.85762 31.5777 7.929 30.4432 7.929C 29.3086 7.929 28.4582 8.85762 28.4582 10.0168C 28.4582 11.046 29.22 11.9138 30.1782 12.0817C 32.556 16.5609 32.747 22.072 30.6106 26.7582C 28.8103 30.5776 25.7926 33.3926 22.0665 34.6851L 22.0614 34.6869C 18.3336 36.0561 14.3187 35.7529 10.8016 33.925C 3.48056 30.1173 0.448866 20.6562 4.049 12.8634C 6.18072 8.26446 10.3461 5.08682 15.0118 4.27801C 15.3555 4.65311 15.8334 4.87564 16.3774 4.87564C 17.5119 4.87564 18.3623 3.94702 18.3623 2.78783C 18.3623 1.62863 17.5119 0.700012 16.3774 0.700012C 15.6422 0.700012 15.0697 1.10548 14.7243 1.65905C 9.18401 2.57177 4.25612 6.35189 1.74641 11.756L 1.74538 11.7583C -0.250678 16.1631 -0.55021 21.1697 0.926879 25.8098C 2.41557 30.4695 5.54358 34.1849 9.64143 36.3984L 9.64677 36.4012C 12.0969 37.6593 14.7301 38.2979 17.2565 38.3C 23.676 38.3 29.8618 34.4989 32.8403 28.0203C 35.3524 22.5326 35.1508 16.0338 32.3055 10.7616Z"/><path id="path4_fill" d="M 19.2915 2.5C 19.2915 3.88071 18.1722 5 16.7915 5C 15.4108 5 14.2915 3.88071 14.2915 2.5C 14.2915 1.11929 15.4108 0 16.7915 0C 18.1722 0 19.2915 1.11929 19.2915 2.5Z"/><path id="path5_fill" d="M 33.2915 10.5C 33.2915 11.8807 32.1722 13 30.7915 13C 29.4108 13 28.2915 11.8807 28.2915 10.5C 28.2915 9.11929 29.4108 8 30.7915 8C 32.1722 8 33.2915 9.11929 33.2915 10.5Z"/><path id="path6_fill" d="M 10.2915 25.5C 10.2915 26.8807 9.17222 28 7.7915 28C 6.41079 28 5.2915 26.8807 5.2915 25.5C 5.2915 24.1193 6.41079 23 7.7915 23C 9.17222 23 10.2915 24.1193 10.2915 25.5Z"/></defs></svg>'
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbDpzcGFjZT0icHJlc2VydmUiIHN0eWxlPSJmaWxsLXJ1bGU6ZXZlbm9kZDtjbGlwLXJ1bGU6ZXZlbm9kZDtzdHJva2UtbGluZWpvaW46cm91bmQ7c3Ryb2tlLW1pdGVybGltaXQ6MiIgdmlld0JveD0iMTMuNCA4LjggNTczLjIgNTczLjIiPgogIDxwYXRoIGZpbGw9IiNhN2FhYWQiIGQ9Ik0xOTUuMTEzIDQxMS4wMzNjNDUuODM1IDQ2LjY5MiAxMTkuMTI0IDU4LjQ4OCAxNzguMzg3IDI0LjI3MyA3MC4yNjItNDAuNTY2IDk0LjM3MS0xMzAuNTQ0IDUzLjgwNi0yMDAuODA2LTQwLjU2Ni03MC4yNjItMTMwLjU0NC05NC4zNzEtMjAwLjgwNi01My44MDYtMTkuODczIDExLjQ3NC0zNi4wNTUgMjYuODk5LTQ4LjEyNCA0NC43MTVsNjQuNzIyIDMzLjE4NmMyMi4yMDEtMjUuNTkzIDU5Ljc5Ni0zMy43ODIgOTEuMjc5LTE3LjYzOSAzNy4wMDIgMTguOTczIDUxLjY0IDY0LjQxOCAzMi42NjcgMTAxLjQyMS0xOC45NzMgMzcuMDAyLTY0LjQxOCA1MS42NC0xMDEuNDIxIDMyLjY2Ny0zMS40ODMtMTYuMTQzLTQ2Ljc3Ni01MS40NS0zOC45NTEtODQuNDE1bC04MS43MDItNDEuODkyYy04LjgzOC00LjUzMi0xMi4zMzUtMTUuMzY3LTcuODE0LTI0LjIxMSAxNS41MTQtMzAuMzQ2IDM5LjY1OC01Ni43MTUgNzEuMzQ0LTc1LjAwOSA4Ny40NjktNTAuNSAxOTkuNDgyLTIwLjQ4NiAyNDkuOTgzIDY2Ljk4MyA1MC41IDg3LjQ2OSAyMC40ODYgMTk5LjQ4Mi02Ni45ODMgMjQ5Ljk4My03NS4yMzUgNDMuNDM3LTE2OC42MyAyNy4zMDctMjI1LjQxOS0zMy43MTctMTcuODA5IDMuNzc4LTM2Ljc5Ny00LjA1NS00Ni4zODctMjAuNjY2LTExLjkyMi0yMC42NDgtNC44MzctNDcuMDkxIDE1LjgxMi01OS4wMTIgMjAuNjQ4LTExLjkyMiA0Ny4wOTEtNC44MzYgNTkuMDEyIDE1LjgxMiA3Ljc3IDEzLjQ1OCA3LjQ2NiAyOS4zNzcuNTk1IDQyLjEzM1oiLz4KICA8cGF0aCBmaWxsPSIjYTdhYWFkIiBkPSJNMjYyLjIzNyA3Mi45ODVDMTQ4LjggOTEuMTAxIDYyIDE4OS40OTQgNjIgMzA4YzAgMTMxLjM1NiAxMDYuNjQ0IDIzOCAyMzggMjM4czIzOC0xMDYuNjQ0IDIzOC0yMzhjMC0zNC4wNTktNy4xNjgtNjYuNDU4LTIwLjA4LTk1Ljc2Ni0xNS4xMjEuOTktMzAuMzIzLTYuMDE0LTM5LjEzNy0xOS42MjYtMTIuOTU5LTIwLjAxNC03LjIzMS00Ni43ODMgMTIuNzgzLTU5Ljc0MiAyMC4wMTQtMTIuOTU4IDQ2Ljc4My03LjIzMSA1OS43NDIgMTIuNzgzIDEwLjA5NSAxNS41OTIgOC44NDkgMzUuMjg0LTEuNjU3IDQ5LjM1MkM1NjUuMjg4IDIyOS40NjEgNTc0IDI2Ny43MjEgNTc0IDMwOGMwIDE1MS4yMjUtMTIyLjc3NSAyNzQtMjc0IDI3NFMyNiA0NTkuMjI1IDI2IDMwOEMyNiAxNzAuNTM5IDEyNy40NDMgNTYuNTg0IDI1OS40ODcgMzYuOTggMjY1LjU5NCAyMC41MzMgMjgxLjQzOCA4LjggMzAwIDguOGMyMy44NDMgMCA0My4yIDE5LjM1NyA0My4yIDQzLjIgMCAyMy44NDMtMTkuMzU3IDQzLjItNDMuMiA0My4yLTE2LjIyOSAwLTMwLjM4LTguOTY4LTM3Ljc2My0yMi4yMTVaIi8+Cjwvc3ZnPgo='
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zach-adams can we create a separate file and function to get the data image?

ravinderk
ravinderk previously approved these changes Sep 8, 2023
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zach-adams I left a minor suggestion which is not a blocker. Let me know if you have questions.

@zach-adams
Copy link
Contributor Author

@ravinderk Moved icon data string to a utility function, let me know if that looks alright

@jeffpaul jeffpaul requested a review from ravinderk September 11, 2023 21:30
@peterwilsoncc peterwilsoncc merged commit c8ce832 into 10up:develop Sep 14, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update admin menu icon to have the same width & height
4 participants