Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin menu icon to have the same width & height #1119

Closed
1 task done
zach-adams opened this issue Aug 4, 2023 · 2 comments · Fixed by #1132
Closed
1 task done

Update admin menu icon to have the same width & height #1119

zach-adams opened this issue Aug 4, 2023 · 2 comments · Fixed by #1132
Assignees
Labels
help wanted type:enhancement New feature or request.
Milestone

Comments

@zach-adams
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

The icon shown in the main WP sidebar for the plugin seems to be very slightly squished width-wise. I found the source SVG at "assets/img/icon.svg" and it seems like it's being set to 36px by 39px in the SVG:
https://github.com/10up/distributor/blob/develop/assets/img/icon.svg

I doubt that squish is intended, if it's not then I propose updating the icon so it has the same width/height. I've created a fixed version of the icon on my own for consideration which you can see in the designs section

It looks like there's also the data URI versions that will need to be updated accordingly in these files:
https://github.com/10up/distributor/blob/develop/includes/external-connection-cpt.php#L665
https://github.com/10up/distributor/blob/develop/includes/settings.php#L309
I'm also not sure if this javascript version will need to be updated as well:
https://github.com/10up/distributor/blob/develop/assets/js/components/plugin-icon.js
Those are all the references to the current icon I could find at a quick glance, but you'll want to check for others

Designs

Existing Icon:
current-icon
Updated Icon:
icon
Example of current icon in the menu:
2023-08-04_14-55-c7759pQK
Example of updated icon in the menu:
2023-08-04_14-51-AwLFn4b4

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zach-adams zach-adams added the type:enhancement New feature or request. label Aug 4, 2023
@jeffpaul jeffpaul added this to the 2.0.1 milestone Aug 8, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Aug 8, 2023
@jeffpaul
Copy link
Member

jeffpaul commented Aug 8, 2023

@peterwilsoncc I don't think there's a reason for an uneven ratio here, is there?

@peterwilsoncc
Copy link
Collaborator

@jeffpaul Not that I can see, I suspect a tpyo.

@zach-adams zach-adams mentioned this issue Sep 7, 2023
4 tasks
@ravinderk ravinderk moved this from To Do to Review Approved in Open Source Practice Sep 13, 2023
@github-project-automation github-project-automation bot moved this from Review Approved to Merged in Open Source Practice Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants