Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Push UI messaging when origin post has ben deleted. #1067

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

peterwilsoncc
Copy link
Collaborator

@peterwilsoncc peterwilsoncc commented Jun 1, 2023

Description of the Change

Updates the Push UI messaging when the origin post has been deleted. This changes to text to use the same message as in the block editor interface.

Per the current behaivour, the message in the push UI only changes on multisite (ie, internal connections).

Screen Shot 2023-06-01 at 3 05 52 pm

Closes #1021

How to test the Change

  1. Install and network activate Distrubtor on a multisite instance of WordPress
  2. Create at least one sub-site
  3. On the main site create and publish a post
  4. Push the post to the sub-site (publish, don't push as a draft).
  5. Trash the post
  6. Open the dashboard of the sub-site
  7. Edit the distributed post on the sub-site
  8. On this branch, the message should appear as in the screen shot above
  9. One the develop branch, the message will invite you to "View original" which links to a 404 error

Changelog Entry

Changed - Indicate if the origin post has been deleted in Distributor push interface.

Credits

Props @peterwilsoncc, @cadic, @jeffpaul, @faisal-alvi.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc self-assigned this Jun 1, 2023
@peterwilsoncc peterwilsoncc added this to the 2.0.0 milestone Jun 1, 2023
@peterwilsoncc peterwilsoncc marked this pull request as ready for review June 2, 2023 01:06
@peterwilsoncc peterwilsoncc requested a review from a team as a code owner June 2, 2023 01:06
@peterwilsoncc peterwilsoncc requested review from faisal-alvi and removed request for a team June 2, 2023 01:06
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Test Result: Pass

image

@peterwilsoncc peterwilsoncc merged commit 667d6a4 into develop Jun 5, 2023
@peterwilsoncc peterwilsoncc deleted the fix/1021-deleted-post-messaging branch June 5, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent messages about the deleted original
2 participants