Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent messages about the deleted original #1021

Closed
1 task done
cadic opened this issue Feb 22, 2023 · 2 comments · Fixed by #1067
Closed
1 task done

Inconsistent messages about the deleted original #1021

cadic opened this issue Feb 22, 2023 · 2 comments · Fixed by #1067
Assignees
Labels
help wanted type:bug Something isn't working.
Milestone

Comments

@cadic
Copy link
Contributor

cadic commented Feb 22, 2023

Describe the bug

On the edit post screen of distributed post, if the original is deleted, the editor notice says:

This Post was distributed from Source site. However, the original has been deleted.

But in the Distributor menu you see

This post was distributed from Source site name. View original

Steps to Reproduce

  1. Create original post
  2. Distribute it to the destination site
  3. Delete the original
  4. Open distributed copy to edit
  5. Read editor notice
  6. Hover on "Distributor" top menu item
  7. Read the message.
  8. The link to Original is 404.

Screenshots, screen recording, code snippet

Distributor.PR.1006.mp4

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cadic cadic added the type:bug Something isn't working. label Feb 22, 2023
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 20, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Mar 20, 2023
@jeffpaul
Copy link
Member

This seems a bit related to #1006, so seems worthwhile to include any further simplification/standardization of copy/messages also within 2.0.0. I might propose the following standardization:
This Post was distributed from source-site-name. However, the origin post has been deleted.

@peterwilsoncc
Copy link
Collaborator

This Post was distributed from source-site-name. However, the origin post has been deleted.

You've suggested linking to the deleted post here. Was that intentional as the link will throw a 404 error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn't working.
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants