-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak: create pot file with WP CLI and move translations to JS files #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I create a bash script which uses package,json -> files to create pot file for addon.
ravinderk
force-pushed
the
fix/translate-js-files-947
branch
from
February 9, 2023 19:17
a8661c7
to
fd218d5
Compare
ravinderk
force-pushed
the
fix/translate-js-files-947
branch
from
February 24, 2023 17:53
17d7548
to
d46277e
Compare
ravinderk
force-pushed
the
fix/translate-js-files-947
branch
from
February 24, 2023 17:59
d46277e
to
c7e1ac4
Compare
ravinderk
changed the title
Add: create pot file with WP cli
Tweak: create pot file with WP cli and move translations to JS files
Mar 6, 2023
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Remove unused trinary condition.
ravinderk
changed the title
Tweak: create pot file with WP cli and move translations to JS files
Tweak: create pot file with WP CLI and move translations to JS files
Mar 7, 2023
# Conflicts: # includes/push-ui.php # includes/syndicated-post-ui.php
@ravinderk FYI, I've pushed in develop after merging #1022 -- I figured I'd do it as I knew it would create merge conflicts that would need to be resolved. |
Co-authored-by: Peter Wilson <[email protected]>
peterwilsoncc
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ravinderk, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I create a bash script that uses
package.json --> files
to create a pot file for the addon. I implementedEnqueueScript
, which manages script dependencies and versions based on the asset file generated by@wordpress/dependency-extraction-webpack-plugin
package.Closes #947 #267 #660
How to test the Change
npm run makepot
command. It should generate a translation file that contains translations from a javascript file (only indist/js
directory).Changelog Entry
Notable Changes
./tests/php/bootstrap.php.dist --> ./tests/php/bootstrap.php
to get code editor support.Todo before release
Checklist: