Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n po/mo not loaded #660

Closed
sebastienserre opened this issue Oct 24, 2020 · 15 comments · Fixed by #1014
Closed

i18n po/mo not loaded #660

sebastienserre opened this issue Oct 24, 2020 · 15 comments · Fixed by #1014
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@sebastienserre
Copy link

Describe the bug
I translated Distributor in french but only strings in the plugin page but the translations are not loaded in the plugin setings it self:
distrubor-fr
distrubor-fr-settings

distributor-fr_FR.zip

Environment information

  • WordPress version: 5.5.1
@sebastienserre sebastienserre added the type:bug Something isn't working. label Oct 24, 2020
@jeffpaul jeffpaul added this to the 1.7.0 milestone Oct 27, 2020
@jeffpaul jeffpaul added type:bug Something isn't working. type:good-first-issue Good for newcomers. help wanted and removed type:bug Something isn't working. labels Oct 27, 2020
@jeffpaul
Copy link
Member

Likely relates to #267.

@dinhtungdu
Copy link
Contributor

@sebastienserre Where did you put your translation file? Your translation is working for me. I put your mo and po files in wp-content/languages/plugins/ directory:
image

@dinhtungdu dinhtungdu added type:question Further information is requested. needs:feedback This requires reporter feedback to better understand the request. and removed type:bug Something isn't working. type:good-first-issue Good for newcomers. help wanted labels Oct 28, 2020
@sebastienserre
Copy link
Author

Thank you @dinhtungdu
I tested in 'lang' folder inside Distributor plugin folder.
If you ship my translations, they won't be loaded.

@dinhtungdu dinhtungdu added type:bug Something isn't working. and removed needs:feedback This requires reporter feedback to better understand the request. type:question Further information is requested. labels Nov 2, 2020
@dinhtungdu
Copy link
Contributor

@sebastienserre Thank you so much! I can confirm this issue. I created #662 to fix this one. If you have time, please give it a review.

@sebastienserre
Copy link
Author

OK I note to test it asap.
I'm quiet new and do not see any "lang/" folder to make a PR with french po/mo ?
How to proceed ?

@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.2 Dec 7, 2020
@jeffpaul jeffpaul modified the milestones: 1.6.2, 1.7.0 Dec 14, 2020
@jeffpaul
Copy link
Member

jeffpaul commented May 7, 2021

I've got Dutch translation files from Geert van der Heide [email protected], so it would be good to finally settle how we handle shipping translations for Distribution. @helen any thoughts/preference on how this is managed outside of WordPress.org's TranslatePress functionality?

@dinhtungdu
Copy link
Contributor

@jeffpaul @helen We can still ship the translations through new releases (I know it's not an optimal way) if we don't have any better solution.

@jeffpaul
Copy link
Member

jeffpaul commented May 6, 2022

@peterwilsoncc curious if you're seen any good examples for how to handle translations for plugins that are not released on WP.org (and thus aren't able to take advantage of the translate.wordpress.org language packs)?

@jeffpaul jeffpaul moved this to Incoming in Open Source Practice May 6, 2022
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice May 6, 2022
@peterwilsoncc
Copy link
Collaborator

@jeffpaul I know of wearerequired/traduttore which sets up a translation interface similar to translate.wordpress.org but I've not used it. It seems fairly actively developed.

@peterwilsoncc
Copy link
Collaborator

We can still ship the translations through new releases (I know it's not an optimal way) if we don't have any better solution.

My inclination is to go down this path for now to avoid perfect being the enemy of the good.

@jeffpaul
Copy link
Member

@peterwilsoncc I think my only concern there is if a new release adjusts where the strings are located wouldn't the translation files be inaccurate and not actually render the translated text as expected?

@peterwilsoncc
Copy link
Collaborator

@jeffpaul Sorry, I am a little unclear what you mean. Are you referring to the strings being relocated within the plugin, the location of the translation files changing or something else?

@jeffpaul
Copy link
Member

@peterwilsoncc talking about the strings being relocated within the plugin

@peterwilsoncc
Copy link
Collaborator

@jeffpaul I don't think that will be a problem, I think the line number references are translatior comments rather used by the files. I tested relocating Howdy, %s on an EN_AU install and the translation to G'day, %s continued working.

@peterwilsoncc
Copy link
Collaborator

I tested wearerequired/traduttore locally and I think it could provide a suitable interface.

As the french translation provided in this original issue are out of date, there's about 40 strings missing, I will move this ticket off the 1.7.0 release as there are no up-to-date translations to include.

I think it would be a poorer experience for 15% of the strings to be untranlated.

@peterwilsoncc peterwilsoncc removed this from the 1.7.0 milestone Jul 15, 2022
@jeffpaul jeffpaul added this to the 2.2.0 milestone Jul 15, 2022
@jeffpaul jeffpaul modified the milestones: 2.2.0, 2.0.0 Jan 30, 2023
@jeffpaul jeffpaul moved this from 🆕 New to 🏗 In progress in Distributor 2.0.0 Feb 1, 2023
@ravinderk ravinderk linked a pull request Mar 6, 2023 that will close this issue
5 tasks
@jeffpaul jeffpaul moved this from 🏗 In progress to 👀 In review in Distributor 2.0.0 Mar 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Distributor 2.0.0 Mar 10, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Merged in Open Source Practice Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Archived in project
Status: Done
5 participants