-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n po/mo not loaded #660
Comments
Likely relates to #267. |
@sebastienserre Where did you put your translation file? Your translation is working for me. I put your mo and po files in |
Thank you @dinhtungdu |
@sebastienserre Thank you so much! I can confirm this issue. I created #662 to fix this one. If you have time, please give it a review. |
OK I note to test it asap. |
I've got Dutch translation files from Geert van der Heide [email protected], so it would be good to finally settle how we handle shipping translations for Distribution. @helen any thoughts/preference on how this is managed outside of WordPress.org's TranslatePress functionality? |
@peterwilsoncc curious if you're seen any good examples for how to handle translations for plugins that are not released on WP.org (and thus aren't able to take advantage of the translate.wordpress.org language packs)? |
@jeffpaul I know of wearerequired/traduttore which sets up a translation interface similar to translate.wordpress.org but I've not used it. It seems fairly actively developed. |
My inclination is to go down this path for now to avoid perfect being the enemy of the good. |
@peterwilsoncc I think my only concern there is if a new release adjusts where the strings are located wouldn't the translation files be inaccurate and not actually render the translated text as expected? |
@jeffpaul Sorry, I am a little unclear what you mean. Are you referring to the strings being relocated within the plugin, the location of the translation files changing or something else? |
@peterwilsoncc talking about the strings being relocated within the plugin |
@jeffpaul I don't think that will be a problem, I think the line number references are translatior comments rather used by the files. I tested relocating |
I tested wearerequired/traduttore locally and I think it could provide a suitable interface. As the french translation provided in this original issue are out of date, there's about 40 strings missing, I will move this ticket off the 1.7.0 release as there are no up-to-date translations to include. I think it would be a poorer experience for 15% of the strings to be untranlated. |
Describe the bug
![distrubor-fr](https://user-images.githubusercontent.com/3902621/97082185-228ac000-1608-11eb-8229-4558d2f0a359.png)
![distrubor-fr-settings](https://user-images.githubusercontent.com/3902621/97082206-49e18d00-1608-11eb-94da-60ba3ea65c1a.png)
I translated Distributor in french but only strings in the plugin page but the translations are not loaded in the plugin setings it self:
distributor-fr_FR.zip
Environment information
The text was updated successfully, but these errors were encountered: