-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for role/user based access #606
Conversation
Overall this looks really good, nice work here @iamdharmesh! I've left a handful of minor code review comments. In addition to that, I have some thoughts on the UI and in particular some text we're showing. In the settings for each feature, we have the following new text strings:
And then on the user profile page, we show:
For some features and settings, this text makes sense (like Open to ideas on any of these strings (especially from @jeffpaul) but I'd recommend the following:
If we want to keep the feature name in there, I think we should change it to something like:
Again, I'd recommend the former over the latter but open to thoughts. I think what we show on the profile page is fine, since it already has the I would recommend though that we standardize on capitalization. Right now most features have the first word capitalized (like Generate captions) but some have both (like Classify Content). I suggest when using the feature name as a description, we should lower case all words. In addition, some of these descriptions have a trailing period and some don't. I think standardizing on no trailing period makes sense. Another thing I'm seeing is that some of these settings descriptions don't have proper spacing (they're too close to the checkbox) while others are fine. See Watson NLU as an example: Looks like there's some CSS scoped to One area we already talked about but just mentioning again is this does make some of these settings pages pretty long (like Azure Image Processing). I think this is fine for now and will be helped once we complete the refactor to have stand-alone features in our settings (and even further once we do a refactor on these settings screens themselves) but just mentioning that there may be complaints on how unwieldy these pages are getting. And I think final thing is looks like we are standardizing on I think something like |
@dkotter @iamdharmesh I pretty much agree with Darin's recommendations in his #606 (comment) |
@dkotter I have added E2E tests, could you please help with re-reviewing this? Thanks |
@iamdharmesh one item that came up in UAT today was the user opt-out links from within the editor/etc. is missing on the Generate Images page linked off the Media Library admin menu. Please ensure we add the opt-out link to the user profile there (if the opt-out setting is allowed) and double-check that we're adding that link across all the ClassifAI features... thanks! |
@jeffpaul I have added a disable feature link to generate images popup and Generate excerpt metabox. Also, please find the status of each feature for the disable link. I have skipped most of the automated features and added a potential UI option to add a link if needed. Could you please help to check and please let me know if you think we should add disable links for the given features? We may handle it in follow-up PR to unblock this PR to be merged. Language Processing:
Image Processing:
cc: @dkotter |
Yeah, if we have places we can easily add this messaging, I think it's worth doing |
Add support controlling feature availability
Description of the Change
This PR adds support for role- and user-based access control to the ClassifiAI feature. It also includes functionality for user-based opt-out, allowing users to choose not to use the specific feature if they prefer not to or if they dislike it.
Feature settings:
User Profile:
Edit User:
In-Context disable feature link to user profile
Note: E2E tests are not added for this new feature.
Closes #588
How to test the Change
Changelog Entry
Credits
Props @jeffpaul @dkotter @iamdharmesh @Sidsector9
Checklist: