Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassifAI panel shows even if NLU feature is turned off #627

Closed
1 task done
dkotter opened this issue Nov 28, 2023 · 0 comments · Fixed by #628
Closed
1 task done

ClassifAI panel shows even if NLU feature is turned off #627

dkotter opened this issue Nov 28, 2023 · 0 comments · Fixed by #628
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Nov 28, 2023

Describe the bug

We added more advanced role and user based access in #606. In testing something else today, I noticed that if I uncheck the Classify content option for the Watson NLU feature but I leave the Enable role-based access option on and set to my role, the ClassifAI panel still shows in the editor, though it is empty. Seems we should remove this panel all together if it isn't needed.

In addition, also noticed that the language-processing.css file seems to load if the NLU feature is turned off but the role-based access is turned on. Wondering if we have some sort of conditional that needs fixed up to ensure the main feature toggle takes precedence and then we look at user and role based access only if the feature is turned on.

Steps to Reproduce

  1. Uncheck the Classify content option for the NLU feature
  2. Check Enable role-based access
  3. Ensure your role is in the allowed list
  4. Go to a post and see the ClassifAI panel in the sidebar

Screenshots, screen recording, code snippet

Screenshot 2023-11-28 at 3 00 40 PM
Screenshot 2023-11-28 at 3 00 46 PM

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added this to the 2.5.0 milestone Nov 28, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Nov 28, 2023
@iamdharmesh iamdharmesh moved this from To Do to In Progress in Open Source Practice Nov 29, 2023
@iamdharmesh iamdharmesh moved this from In Progress to In Review in Open Source Practice Nov 29, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants