Add acceptance tests

[johnwatkins0]

Description of the Change

Resolves #17 by adding and configuring WP Acceptance and setting up a snapshot for testing.
Resolves #19 by adding an initial set of acceptance tests covering post save functionality.

Alternate Designs

Further tests could be added to cover the settings page.

Benefits

Acceptance tests can now be added for new features and bug fixes.

Possible Drawbacks

Verification Process

Tests in the GH Actions CI process should all pass.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Changelog Entry

• Added WP Acceptance tests

[johnwatkins0]

@jeffpaul We'll need AWS_ACCESS_KEY and SECRET_ACCESS_KEY added to the repo secrets for the WP Acceptance snapshot. I adapted this line from Distributor, which uses Travis and passes Travis user credentials, though it should work the same in the GH action.

[johnwatkins0]

@dinhtungdu This is ready for review. Took me 1,000 commits to get the WP Acceptance tests to pass 😫

[johnwatkins0]

I will create a follow-up issue for this when this PR is merged. We'll need to switch back to the main WP Acceptance repo after Felipe's PR is merged.

[jeffpaul]

@johnwatkins0 FYI that WPA has been updated from Felipe's PR.

[dinhtungdu]

Can we run tests on 7.2 too?

[johnwatkins0]

@jeffpaul @dinhtungdu I'm having a lot of trouble with the GitHub action for this. After getting Acceptance tests to pass, the action is now failing on PHPUnit because mysql doesn't appear to be available in the container as of yesterday. I don't know what changed. I've done some searching in the GH forums and so far no one else is having this problem.

I propose:
(1) @dinhtungdu take a look at the most recent failing test action and the test.yml workflow and see if you see anything I might be missing.
(2) If no solution presents itself, we switch to Travis.

[jeffpaul]

@johnwatkins0 last year we had an odd issue on ClassifAI and Travis and had to add this line to get things working again: https://github.com/10up/classifai/blob/978d79c9c6d1573a65bbac2db787366125a6f94f/.travis.yml#L27

It looks like you've got something similar in https://github.com/10up/autoshare-for-twitter/blob/feature/wp-acceptance-tests/.github/workflows/test.yml so maybe something's off in the way we're referencing mysql in that YML file?

[johnwatkins0]

@jeffpaul Yeah, last night I found myself back in that Slack conversation about the missing mysql in the Travis config, so several of my recent failed test runs here are me trying different things to get mysql set up in the Actions environment without success. Before switching to Travis I do want to take a little more time to try to resolve it, but I also don't want this to block 1.0.2 if I can't figure it out quickly.

[jeffpaul]

@johnwatkins0 anything else planned on this PR or are we good to merge this in an have some fun new tests?

[johnwatkins0]

@jeffpaul Yes, it's good to merge. I removed a couple of my more complicated acceptance tests in my last commit, specifically:

1. A test that checked the autoshare box, saved the draft, unchecked the autoshare box, published the post, and verified no tweet was sent
2. A test that saved a draft with the autoshare box unchecked, checked the box on the following pageload, published the post, and verified that the tweet was sent

Both of these tests were failing about 25% of the time. This is a little worrying, but I have not been able to replicate the failures in manual testing. If there is a bug in those scenarios, I think it's one that requires super-fast fingers for a human to replicate. Maybe we could merge this in and create a new issue for WP Acceptance tests for those two scenarios.