Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Set up WP Acceptance #83

Closed
wants to merge 33 commits into from
Closed

WIP: Set up WP Acceptance #83

wants to merge 33 commits into from

Conversation

johnwatkins0
Copy link
Member

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul added this to the 1.1.0 milestone Mar 6, 2020
dinhtungdu added 25 commits March 6, 2020 16:36
@dinhtungdu
add: plugin actions link to setting page
7331ec4
@dinhtungdu
add: branding and two columns style
9c91b25
@dinhtungdu
add: js to handle show/hide credential settings
de08a68
@dinhtungdu
add: show instruction only if the account isn't configured
5364719
@dinhtungdu
add: general setting sections
6930206
@dinhtungdu
add: post types settings
3f7db39
@dinhtungdu
add: show/hide post types settings
46e0caf
@dinhtungdu
add: respect post types that are supported by code
a2e5f78
@dinhtungdu
fix: unit test case
e32825d
@dinhtungdu
fix: coding standard
d22a4b6
@dinhtungdu
add: support and installation links
ef38c9b
@dinhtungdu
fix: hide setting if twitter is not configured
ea79ca0
@dinhtungdu
update: detailed instruction on connecting twitter
eabdc28
@dinhtungdu
add: enable default setting and handler
031dae5
@dinhtungdu
add: enable upload setting and handler
725ff33
@dinhtungdu
fix(settings): udpate help links
2a6fc02
@dinhtungdu
fix(settings): use <code> for better readability
bc77a88
@dinhtungdu
fix(settings): use correct domain format
88a0da3
@dinhtungdu
fix(settings): label and placeholder
69aa76b
@dinhtungdu
fix(settings): default select Selected content types only
730a529
@dinhtungdu
fix(settings): show instructions when the connection settings are exp…
f078c07 
…anded
@dinhtungdu
fix: settings labels
0add74f
@dinhtungdu
fix: only show credentials settings toggle links when connected
a4faac8
@dinhtungdu
fix: reorder action links
6f8286e
@dinhtungdu
fix: typo and cleanup
3714777
@johnwatkins0 johnwatkins0 reopened this Mar 6, 2020
@johnwatkins0
Copy link
Member Author

Closing in favor of #84

@johnwatkins0 johnwatkins0 deleted the feature/acceptance-tests branch March 8, 2020 18:28
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.2 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul will be requested when the pull request is marked ready for review jeffpaul is a code owner

@dkotter dkotter Awaiting requested review from dkotter dkotter will be requested when the pull request is marked ready for review dkotter is a code owner

Assignees

@johnwatkins0 johnwatkins0

Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@johnwatkins0 @jeffpaul @dinhtungdu