Fixed incorrect Tweet this post checkbox behavior in the classic editor.

[iamdharmesh]

Description of the Change

As described in #168, Currently, whenever we Save draft post with the Tweet this post checkbox checked, it always tweets post when we publish a post, even when we publish a post with the Tweet this post checkbox unchecked.

This is happening because when the checkbox is unchecked, it won't send with $_POST data and the plugin uses the existing value of the meta field (check here). Which is enabled. So, the tweet is always get posted.

This PR contains changes to handle the unchecked "Tweet this post" checkbox for the classic editor and fix the reported issue.

Closes #168

Alternate Designs

Possible Drawbacks

Verification Process

1. Install the Classic Editor plugin.
2. Create a draft post in the classic editor (make sure the Tweet this post checkbox is checked).
3. Try to uncheck the checkbox and Save draft.
4. Verify checkbox is unchecked.
5. Check the checkbox and Save draft.
6. Uncheck the checkbox and Publish post.
7. Make sure the post is not tweeted.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Changelog Entry

Fixed - Incorrect Tweet this post checkbox behavior in the classic editor.

Credits

Props @iamdharmesh

[cadic]

LGTM!

@iamdharmesh not as part of the current PR, do you think it worth to add new test (unit or e2e) to cover this situation?

[iamdharmesh]

Yes, @cadic I have added this situation to e2e tests in PR #167, and during the debug on test failing I found this issue. :)