Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run E2E tests with Enable by default option checked and unchecked. #167

Merged
merged 7 commits into from
Jun 6, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As requested in #158, current E2E tests run with Enable by default option disabled. This PR made changes to run E2E tests with Enable by default checked and unchecked both to make sure it works as expected with both scenarios.

Closes #158

Alternate Designs

Possible Drawbacks

Verification Process

GH actions for E2E tests should PASS.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Some addtional E2E tests

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Jun 1, 2022
@iamdharmesh iamdharmesh marked this pull request as draft June 1, 2022 07:45
@iamdharmesh iamdharmesh requested review from a team and Sidsector9 and removed request for a team June 3, 2022 12:26
@iamdharmesh iamdharmesh marked this pull request as ready for review June 3, 2022 12:26
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@jeffpaul jeffpaul merged commit 650cf1c into develop Jun 6, 2022
@jeffpaul jeffpaul deleted the enhancement/158 branch June 6, 2022 15:25
@iamdharmesh iamdharmesh modified the milestones: 1.2.0, 1.1.2 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Additional E2E tests
3 participants