Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline failures #147

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Fix pipeline failures #147

merged 2 commits into from
Mar 18, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Mar 18, 2022

Description of the Change

Basically, This PR is completes the work of #120, and it fixes pipeline failures. (#120 is old and contains conflicts so, raising new PR for a faster fix.)
Changes:

  1. Added yoast/phpunit-polyfills composer package
  2. Removed "wp-acceptance" test checks (We already have Draft PR for migrate to cypress e2e tests So, just disabling test check here to stop it keep failing)

Alternate Designs

Fix "wp-acceptance" tests (but as we are migrating to new e2e framework better to make it disable for now)

Possible Drawbacks

none

Verification Process

Ensure the pipeline for this PR passes

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix: CI Pipeline failures.

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Mar 18, 2022
@iamdharmesh iamdharmesh marked this pull request as ready for review March 18, 2022 13:27
@iamdharmesh iamdharmesh requested review from a team and Sidsector9 and removed request for a team March 18, 2022 13:28
@iamdharmesh iamdharmesh added this to the 1.1.0 milestone Mar 18, 2022
@jeffpaul jeffpaul merged commit de17044 into develop Mar 18, 2022
@jeffpaul jeffpaul deleted the fix/pipeline branch March 18, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants