Add cypress tests #145

thrijith · 2022-03-09T13:44:25Z

Description of the Change

Setup cypress automated testing

Closes #91

Alternate Designs

N/A

Possible Drawbacks

N/A

Verification Process

Checklist:

I have read the CONTRIBUTING document.
[ x My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests passed.

Changelog Entry

Credits

Props @

Add admin page tests Add block editor tests

jeffpaul · 2022-03-11T14:53:36Z

@thrijith what else is needed here to bring out of draft? (also, THANKS for helping on this!)

thrijith · 2022-03-11T15:00:07Z

@thrijith what else is needed here to bring out of draft? (also, THANKS for helping on this!)

Hi @jeffpaul, the last test ran successfully here https://github.com/10up/autoshare-for-twitter/runs/5512545638?check_suite_focus=true#step:8:155 but I am seeing issue with same test when run against different WP version, don't think it is due version but something else, I'll check and see how it goes and update the PR when ready, hope that works 🙂

cadic

reviewed by accident

thrijith · 2022-03-21T16:44:37Z

Hi @jeffpaul

I have the test ready, but there are issues when it is running on GH actions, and the videos generated as part of the process doesn't help in pinpointing the issue here, would be really helpful if someone can take a look at this as well.

Initially the test were failing for all WP versions, but one passed when I ran it individually.

https://github.com/10up/autoshare-for-twitter/blob/feature/add-cypress-tests/.github/workflows/test.yml#L64-L68

The minimum and trunk versions fail too and the videos generated in test don't have info adding links to the results https://drive.google.com/drive/folders/1WG8SnhQglIgLHvwETy1DBm9BG6QywNi6?usp=sharing
I ran those test locally and they pass so not sure how to proceed on this one right now, test on WP minimum, test on WP trunk

iamdharmesh · 2022-03-24T06:09:00Z

Hi @thrijith,

Test failure in minimum and trunk env issue is fixed now. You may continue now on this to make it ready for review.

Thanks

thrijith · 2022-03-24T11:46:09Z

Test failure in minimum and trunk env issue is fixed now. You may continue now on this to make it ready for review.

@iamdharmesh awesome, thanks! also what was the issue though? I see you moved permalink setup to be done after env setup was that is?

I'll check the requirements in https://github.com/10up/autoshare-for-twitter/issues/91and see if anything new needs to be done here or not in sometime.

iamdharmesh · 2022-03-24T13:46:20Z

@iamdharmesh awesome, thanks! also what was the issue though? I see you moved permalink setup to be done after env setup was that is?

@thrijith The issue is related to some file permissions when we specify custom WordPress version for wp-env in .wp-env.json or .wp-env-override.json. In this case .htaccess file couldn’t be created in the root folder of the testing website. This is a known issue and fixed by @cadic. So, I applied his solution here

Update permission of test core version setting Update description for edit page Remove test for actual tweet test Remove secrets passed in test action

Update tests and add block editor and classic editor cypress tests Remove wpacceptance Pass env vars via command line option

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.10.2...v6.12.6) --- updated-dependencies: - dependency-name: ajv dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [tar](https://github.com/npm/node-tar) from 4.4.8 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.8...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Update upload artifact action for debugging Update upload artifact action for debugging

Check if dialog is working in CI Revert "Check if dialog is working in CI" This reverts commit 85adb37.

Add composer to test run fix syntax Set permalink for unique URL Add helper function to get random text Set video to true for testing Revert "Set video to true for testing" This reverts commit 1446c60.

…config to enable video Rename test files for order Add more time to check for tweet Try fixing issue with tests in different WP versions Add timeout before click and additional step for lower version metabox Reduce timeouts in tests Temporarily remove trunk from matrix tests Revert "Temporarily remove trunk from matrix tests" This reverts commit 1a5576b.

iamdharmesh · 2022-03-30T04:31:30Z

@thrijith considering your comment here #91 (comment), making this PR Ready for review.

dinhtungdu

@thrijith overall, the PR looks good to me, great work 🎉 !

I notice you use cy.wait quite often, can you try to reduce or eliminate the usage of timeout functions? Because using timeout is a signal of potential flaky tests.

… into feature/add-cypress-tests

iamdharmesh · 2022-04-11T07:10:31Z

Hi @dinhtungdu,

I have updated PR for utilizing our utils lib @10up/cypress-wp-utils and improved tests by removing wait and timeout-related stuff.

Please help to re-review it.

Thanks
cc: @thrijith

tests/cypress/support/commands.js

dinhtungdu

LGTM! Left an optional comment but pre-approving this! Thanks so much for the great work on this PR!

tests/cypress/integration/block-editor.test.js

thrijith added 2 commits December 17, 2021 23:30

Add check before adding event listener

68e9700

Initial setup for Cypress test

03991ca

Add admin page tests Add block editor tests

jeffpaul assigned thrijith Mar 11, 2022

jeffpaul added this to the 1.1.0 milestone Mar 11, 2022

cadic previously approved these changes Mar 14, 2022

View reviewed changes

cadic self-requested a review March 14, 2022 08:52

thrijith dismissed cadic’s stale review via 1446c60 March 18, 2022 08:11

iamdharmesh mentioned this pull request Mar 18, 2022

Fix pipeline failures #147

Merged

6 tasks

thrijith force-pushed the feature/add-cypress-tests branch from 1be7125 to 54ce129 Compare March 28, 2022 19:09

thrijith and others added 15 commits March 29, 2022 00:49

Add option to set twitter creds

7b88796

Update permission of test core version setting Update description for edit page Remove test for actual tweet test Remove secrets passed in test action

Update composer to add yoast polyfills library

0249026

Test tweet feature

5fffb22

Update tests and add block editor and classic editor cypress tests Remove wpacceptance Pass env vars via command line option

update wp tested-up-to badge in README.md

5cb50c9

feat: add colored icons for autoshare status

dba0123

fix: code review improvisations

487faec

Add upload artifact action for debugging

15dfd5d

Update upload artifact action for debugging Update upload artifact action for debugging

Add wp-env conf

614fa6c

Check if dialog is working in CI Revert "Check if dialog is working in CI" This reverts commit 85adb37.

Add composer to test run

b64557c

Add composer to test run fix syntax Set permalink for unique URL Add helper function to get random text Set video to true for testing Revert "Set video to true for testing" This reverts commit 1446c60.

Added 'yoast/phpunit-polyfills' lib

ff1b847

Removed "wp-acceptance" cases

1a55e88

Moved Update permalink structure to initialize script.

7369514

thrijith mentioned this pull request Mar 29, 2022

Add acceptance tests #91

Closed

2 tasks

iamdharmesh marked this pull request as ready for review March 30, 2022 04:31

dinhtungdu reviewed Mar 30, 2022

View reviewed changes

iamdharmesh mentioned this pull request Apr 1, 2022

Release version 1.1.0 #150

Closed

19 tasks

iamdharmesh added 11 commits April 11, 2022 10:03

Merge branch 'develop' of https://github.com/10up/autoshare-for-twitter…

13f6a34

… into feature/add-cypress-tests

Added @10up/cypress-wp-utils package and started on improve tests.

be4e515

improved block-editor-a-test.js tests.

b38f213

fix uncheck "enable default"

ff3bb0f

Improve block editor tests.

2c0663c

Improve classic editor tests

26a9ac6

remove unwanted "cypress-file-upload" package.

a20ef5c

rename test.yml to cypress & update 5.2.11 -> 5.2 WP minimum

eccab4c

further improvements to block editor tests.

cf67591

further improvements to classic editor tests.

9b392da

Fixed WP minimum failures.

6a2fa0e

dinhtungdu reviewed Apr 11, 2022

View reviewed changes

tests/cypress/support/commands.js Outdated Show resolved Hide resolved

Removed visitAdminPage command.

f308b74

iamdharmesh requested a review from dinhtungdu April 11, 2022 10:13

iamdharmesh self-assigned this Apr 11, 2022

dinhtungdu previously approved these changes Apr 11, 2022

View reviewed changes

tests/cypress/integration/block-editor.test.js Outdated Show resolved Hide resolved

Preserve WP cookies for one time login

69fbba2

iamdharmesh dismissed dinhtungdu’s stale review via 69fbba2 April 11, 2022 11:10

fix typo.

e64ae36

iamdharmesh requested a review from dinhtungdu April 11, 2022 11:49

dinhtungdu approved these changes Apr 11, 2022

View reviewed changes

iamdharmesh merged commit 4df6a36 into develop Apr 11, 2022

iamdharmesh deleted the feature/add-cypress-tests branch April 11, 2022 12:55

iamdharmesh mentioned this pull request Apr 13, 2022

fix/154: Fix autotweet when autoshare enabled by default. #155

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cypress tests #145

Add cypress tests #145

thrijith commented Mar 9, 2022

jeffpaul commented Mar 11, 2022

thrijith commented Mar 11, 2022

cadic left a comment •

edited

Loading

thrijith commented Mar 21, 2022

iamdharmesh commented Mar 24, 2022

thrijith commented Mar 24, 2022

iamdharmesh commented Mar 24, 2022

iamdharmesh commented Mar 30, 2022

dinhtungdu left a comment

iamdharmesh commented Apr 11, 2022

dinhtungdu left a comment

Add cypress tests #145

Add cypress tests #145

Conversation

thrijith commented Mar 9, 2022

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

Changelog Entry

Credits

jeffpaul commented Mar 11, 2022

thrijith commented Mar 11, 2022

cadic left a comment • edited Loading

Choose a reason for hiding this comment

thrijith commented Mar 21, 2022

iamdharmesh commented Mar 24, 2022

thrijith commented Mar 24, 2022

iamdharmesh commented Mar 24, 2022

iamdharmesh commented Mar 30, 2022

dinhtungdu left a comment

Choose a reason for hiding this comment

iamdharmesh commented Apr 11, 2022

dinhtungdu left a comment

Choose a reason for hiding this comment

cadic left a comment •

edited

Loading