Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mime type change for .gif files #76

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

doekenorg
Copy link
Contributor

@doekenorg doekenorg commented Aug 20, 2021

Description of the Change

Screenshots can be .gif files. These are useful for showing the interaction the user can expect. The mime-type of .gif files is not updated. This PR adds that.

Alternate Designs

None. I can do it by hand every time 😄

Benefits

.gif files in the assets-folder will automatically have the correct mime type, and this will prevent people from downloading the file, instead of viewing it in the browser.

Possible Drawbacks

If you really want people to download the .gif files, this would prevent that. I think the chances of this are slim to non-existent.

Verification Process

There is really nothing to verify; other than that you can actually use .gif as a screenshot. Take a look at our screenshot section for an example.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

### Added
- Added mime type change to `image/gif` for `.gif` files.

@jeffpaul jeffpaul added this to the 2.1.0 milestone Jan 5, 2022
@jeffpaul jeffpaul linked an issue Jan 5, 2022 that may be closed by this pull request
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

@jeffpaul jeffpaul merged commit baea4b3 into 10up:develop Jan 7, 2022
@doekenorg doekenorg deleted the fix_gif_mime branch February 13, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mime type of .gif asset files are not updated
4 participants