Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mime type of .gif asset files are not updated #75

Closed
doekenorg opened this issue Aug 20, 2021 · 2 comments · Fixed by #76
Closed

Mime type of .gif asset files are not updated #75

doekenorg opened this issue Aug 20, 2021 · 2 comments · Fixed by #76
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@doekenorg
Copy link
Contributor

Describe the bug
Screenshots can be .gif files. These are useful for showing the interaction the user can expect. The mime-type of .gif files is not updated. So the file will be downloaded, instead of shown in the browser.

Steps to Reproduce

  1. Create a repo with an assets folder that contains a .gif file
  2. Run the action
  3. Click the screenshot in the WordPress plugin page

Expected behavior
The file will open in the browser.

Additional context
PR added.

@doekenorg doekenorg added the type:bug Something isn't working. label Aug 20, 2021
@jeffpaul
Copy link
Member

Note that WP.org only states support for PNG or JPG filetypes for screenshots: https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/#filenames-3. Also, they do not state support for GIF for any plugin asset type for that matter.

@doekenorg doekenorg reopened this Aug 20, 2021
@doekenorg
Copy link
Contributor Author

Sorry, working in my phone now and accidentally clicked the closing button.

It is pretty tucked away, but you can find a reference to this in the readme example. https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/#example-readme

This is how I found it was possible.

@jeffpaul jeffpaul linked a pull request Jan 5, 2022 that will close this issue
6 tasks
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jan 5, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Jan 5, 2022
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice Jan 5, 2022
Repository owner moved this from In Review to Merged in Open Source Practice Jan 7, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants