Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default DRY_RUN to false #127

Merged
merged 1 commit into from
May 8, 2023
Merged

Set the default DRY_RUN to false #127

merged 1 commit into from
May 8, 2023

Conversation

mukeshpanchal27
Copy link
Contributor

@mukeshpanchal27 mukeshpanchal27 commented Apr 28, 2023 •
edited
Loading

The follow-up changes that were missed in #122 In this PR, set the default value for DRY_RUN to false.

Closes #126

Credits

Props @mukeshpanchal27, @joemcgill, @felixarntz, @aaemnnosttv, @stephywells

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review April 28, 2023 05:31
@mukeshpanchal27 mukeshpanchal27 requested a review from a team as a code owner April 28, 2023 05:31
@mukeshpanchal27 mukeshpanchal27 self-assigned this Apr 28, 2023
@mukeshpanchal27 mukeshpanchal27 added the needs:code-review This requires code review. label Apr 28, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the 2.2.0 milestone Apr 28, 2023
joemcgill
joemcgill approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look correct to me. Thanks @mukeshpanchal27!

@jeffpaul jeffpaul merged commit 981693f into 10up:develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcgill joemcgill joemcgill approved these changes

@aaemnnosttv aaemnnosttv Awaiting requested review from aaemnnosttv

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Dry run is on by default
3 participants
@mukeshpanchal27 @joemcgill @jeffpaul