Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run is on by default #126

Closed
stephywells opened this issue Apr 25, 2023 · 2 comments · Fixed by #127
Closed

Dry run is on by default #126

stephywells opened this issue Apr 25, 2023 · 2 comments · Fixed by #127
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@stephywells
Copy link

Describe the bug
Since https://github.com/10up/action-wordpress-plugin-deploy/pull/122/files, the dry run is triggered and files are not pushed. Here's an example:
https://github.com/Strategy11/business-directory-plugin/actions/runs/4802423433/jobs/8545863161#step:4:45

Steps to Reproduce

  1. Add the standard config in a workflow:
    - name: WordPress Plugin Deploy
      uses: 10up/action-wordpress-plugin-deploy@develop
  1. Trigger the workflow.
  2. No files are pushed, and the new dry run messages are shown in the log.

Expected behavior
The plugin should be pushed to SVN.

@stephywells
Copy link
Author

The workaround is to add this to the config:

env:
  INPUT_DRY_RUN: false

@jeffpaul
Copy link
Member

@stephywells thanks for the report, that was caught post-merge and will get resolved.

@mukeshpanchal27 you can utilize this issue for the PR you're working on.

@jeffpaul jeffpaul added this to the 2.2.0 milestone Apr 26, 2023
@jeffpaul jeffpaul added the type:bug Something isn't working. label Apr 26, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Apr 26, 2023
@mukeshpanchal27 mukeshpanchal27 moved this from To Do to In Review in Open Source Practice Apr 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants