Strip slashes when saving features. #2753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Strips slashes from post data when saving settings. Not doing this was leading to double slashing when settings were saved to the database, which was particularly notable when using an attribute selector for Autosuggest.
Closes #2731
Alternate Designs
NA
Possible Drawbacks
NA
Verification Process
Go to ElasticPress > Features and save
input[type="text"]
as the Autosuggest Selector, then refresh the page. Previously the saved value would appear asinput[type=\"text\"]
and be double slashed asinput[type=\\\"text\\\"]
in the database. With this change it should show as it was entered, and only be single slashed in the database.Checklist:
Changelog Entry
Credits
Props @JakePT