Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: input[type="text] selector not working with autosuggest #2731

Closed
oscarssanchez opened this issue Apr 28, 2022 · 0 comments · Fixed by #2753
Closed

BUG: input[type="text] selector not working with autosuggest #2731

oscarssanchez opened this issue Apr 28, 2022 · 0 comments · Fixed by #2753
Assignees
@JakePT
Labels
bug Something isn't working module:autosuggest Issues related to the Autosuggest functionality
Milestone
4.2.0

Comments

@oscarssanchez
Copy link
Contributor

oscarssanchez commented Apr 28, 2022 •
edited
Loading

Describe the bug

When we save input input[type="text"] as a selector to be used with autosuggest, it gets saved as input[type=\"text\"], therefore autosuggest can’t find the correct element.

Steps to Reproduce

  1. Go to autosuggest settings
  2. Set selector input[type=\"text\"]
  3. Try to search in autosuggest

Expected behavior

It should work with this selector.

Screenshots

Environment information

  • Device:
  • OS:
  • Browser and version:
  • WordPress version:
  • ElasticPress version:
  • Elasticsearch version:
  • Where do you host your Elasticsearch server?
  • What ElasticPress features do you have currently active?
  • Plugins and version:
  • Theme and version:
  • Site Health Info:

Additional context
@oscarssanchez oscarssanchez added the bug Something isn't working label Apr 28, 2022
@felipeelia felipeelia added this to the 4.2.0 milestone May 3, 2022
@felipeelia felipeelia added the module:autosuggest Issues related to the Autosuggest functionality label May 3, 2022
JakePT added a commit that referenced this issue May 11, 2022
@JakePT
Strip slashes when saving features. Fixes #2731.
183b86a
@JakePT JakePT mentioned this issue May 11, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakePT JakePT

Labels
bug Something isn't working module:autosuggest Issues related to the Autosuggest functionality
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Strip slashes when saving features. 10up/ElasticPress
3 participants
@felipeelia @JakePT @oscarssanchez