[TECH] Aligner les couleurs de pix-site #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celineung
added
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
celineung
force-pushed
the
tech-design-system-colors
branch
2 times, most recently
from
674e47a to
5f05375
Compare
MelanieMEB
approved these changes
Oct 13, 2020
sbedeau
approved these changes
Oct 13, 2020
jonasgrilleres
approved these changes
Oct 13, 2020
celineung
force-pushed
the
tech-design-system-colors
branch
from
4001761 to
6075ff2
Compare
celineung
force-pushed
the
tech-design-system-colors
branch
from
6075ff2 to
478c0ec
Compare
jonasgrilleres
approved these changes
Oct 13, 2020
alexandrecoin
approved these changes
Oct 13, 2020
celineung
force-pushed
the
tech-design-system-colors
branch
from
478c0ec to
483b7fa
Compare
sbedeau
approved these changes
Oct 13, 2020
components/slices/Process.vue
Outdated
Comment on lines
188
to
189
| box-shadow: 0 24px 32px 0 rgba(#000000, 0.03), | ||
| 0 8px 32px 0 rgba(#000000, 0.06); |
There was a problem hiding this comment.
nitpick (non-blocking): Je pense qu'il faut déclarer un $black ou utiliser un gris très foncé pour éviter ce genre de déclaration et ainsi être conforme aux standards
There was a problem hiding this comment.
Corrigé pour du $grey-200, validé avec Quentin: la règle est de ne jamais prendre #000000
MelanieMEB
approved these changes
Oct 13, 2020
celineung
force-pushed
the
tech-design-system-colors
branch
from
483b7fa to
c4fbc4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le fichiers colors.scss s'enrichi de plus en plus et s'éloigne du design system.
🤖 Solution
🌈 Remarques
colors.scss(sauf concertation avec Quentin)💯 Pour tester
Vérifications visuelles avec Quentin en cours.
Vérifier que tous les textes des pages sont biens visibles.