[FEATURE] Création du bloc Statistiques et refacto (PIX-1200). #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrecoin
added
🚧 Development in progress
team-evaluation
alexandrecoin
commented
Oct 12, 2020
MelanieMEB
reviewed
Oct 12, 2020
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
4 times, most recently
from
17620b5 to
1a96585
Compare
|
I'm deploying this PR to these urls:
Please check it out! |
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
7 times, most recently
from
2fe9df1 to
7d7438c
Compare
alexandrecoin
added
👀 Func Review Needed
👀 Tech Review Needed
and removed
🚧 Development in progress
labels
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
2 times, most recently
from
1980fce to
627f1db
Compare
|
Question : est-ce que le passage de Feature/etc. à MultipleBlock coté Prismic demandera de modifier tous les composants existants ? Il faudrait du downtime ? |
Il faudra recréer chaque composant sur Prismic vu qu'il n'est pas possible de modifier le type d'un composant créé sur le document. (Il peuvent seulement être déplacés sur la page et/ou supprimés) Du downtime ? A quel niveau ? |
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
2 times, most recently
from
d2a8b71 to
cd93de5
Compare
sbedeau
approved these changes
Oct 15, 2020
| @@ -53,6 +53,9 @@ | |||
| <template v-if="slice.slice_type === 'process'"> | |||
| <process-slice :slice="slice" /> | |||
| </template> | |||
| <template v-if="slice.slice_type === 'multiple_block'"> | |||
| <multiple-block-slice :slice="slice" /> | |||
There was a problem hiding this comment.
suggestion (non-blocking):
Suggested change
| <multiple-block-slice :slice="slice" /> | |
| <key-elements-slice :slice="slice" /> |
sbedeau
approved these changes
Oct 15, 2020
MelanieMEB
approved these changes
Oct 15, 2020
|
thought (non-blocking): C'est peut-être une bonne occasion pour mettre des tests ? |
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
from
4dd063e to
65e1aa8
Compare
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
from
65e1aa8 to
20c3396
Compare
alexandrecoin
force-pushed
the
pix-1200-new-multiple-use-block
branch
from
20c3396 to
eb4d9bf
Compare
celineung
approved these changes
Oct 16, 2020
alexandrecoin
added
Func Review OK
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Il manque un bloc statistique contribuable par la team Contenu sur Prismic.
🤖 Solution
Ce nouveau bloc présentant les mêmes caractéristiques au niveau du
templateet duscriptque les blocs Feature et Process, nous avons opté pour une refacto de ces trois composants avec des appels à des fichiers SCSS externes et propres à chacun des blocs en fonction du type de ces derniers à créer sur Prismic.MultipleBlock(Prismic et code) reprenant le template et la logique des composants Process, Features et Statsassets/scssafin de copier l'architecture du dossier de composants Vue (components/slices) avec ajout des styles des différents composants faisant appel à MultipleBlock🌈 Remarques
Je me demande si
MultipleBlockest un nom pertinent pour ce composant. 🧐Je n'ai pas réussi à trouver quelque chose de succinct pour exprimer la réutilisation possible de ce composant par différents blocs dans Prismic.
✨ Review App
https://site-pr193.review.pix.fr/
https://pro-pr193.review.pix.fr/