Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reproducible bundles #9

Closed
dckc opened this issue Aug 3, 2023 · 9 comments
Closed

reproducible bundles #9

dckc opened this issue Aug 3, 2023 · 9 comments
Assignees
@dckc
Milestone
launch critical

Comments

@dckc
Copy link
Collaborator

dckc commented Aug 3, 2023

I'd like to be able to reproduce the bundles.

How about sharing a fork/branch of agoric-sdk with your tweaks?
0xpatrickdev added a commit that referenced this issue Aug 8, 2023
@0xpatrickdev
feat: updates bundles with latest build
dad8bda 
- use STATOM1 instead STATOM for testing
- limit powers in oracle proposal (economicCommitteeCreatorFacet, contractGovernor) see #5
- use testnet oracle address (+ my own) see #3
- bundles: use node v16.18.1, go 1.20.2, agoric-sdk master#9d4eaad see #9
@dckc
Copy link
Collaborator Author

dckc commented Aug 9, 2023 •
edited
Loading

In #11 I see you shared
Agoric/agoric-sdk@master...0xpatrickdev:agoric-sdk:pc/statom-vault-proposal

Thanks. Here's hoping I can reproduce the bundles.

I currently see that branch is at 59581aa

@dckc
Copy link
Collaborator Author

dckc commented Aug 9, 2023 •
edited
Loading

I'm not (yet) able to reproduce these bundles. I'm able to match the bundles on the feat/statom1 branch.

When I check out the pc/statom-vault-proposal branch, git log tells me it's currently at 59581aa10. I did yarn && yarn build and then agoric run scripts/add-STARS.js in packages/inter-protocol. The resulting bundle IDs don't match what I see in the README here.

agoric run scripts/add-STARS.js log 
$ cd packages/inter-protocol/
packages/inter-protocol$ yarn build:add-STARS-proposal
yarn run v1.22.19
$ agoric run scripts/add-STARS.js
agoric: run: running /home/connolly/projects/ag-statom/packages/inter-protocol/scripts/add-STARS.js
agoric: run: Deploy script will run with Node.js ESM
bundle-source --to /home/connolly/projects/ag-statom/packages/inter-protocol/bundles /home/connolly/projects/ag-statom/packages/zoe/src/contracts/scaledPriceAuthority.js scaledPriceAuthority
/home/connolly/projects/ag-statom/packages/inter-protocol/bundles bundle-scaledPriceAuthority.js valid: 136 files bundled at 2023-08-09T20:03:41.533Z
creating add-STARS-permit.json
creating add-STARS.js
You can now run a governance submission command like:
  agd tx gov submit-proposal swingset-core-eval add-STARS-permit.json add-STARS.js \
    --title="Enable <something>" --description="Evaluate add-STARS.js" --deposit=1000000ubld \
    --gas=auto --gas-adjustment=1.2
Remember to install bundles before submitting the proposal:
  agd tx swingset install-bundle @/home/connolly/.agoric/cache/b1-e4ba9cb60b5b59d4d4618710991fe8a503dd4a07c7f17029a342ccb41893bc961ae63bcb0e2c20e4bc2415c9755f090f7761751cdd00b85762902b357a48c5cf.json
  agd tx swingset install-bundle @/home/connolly/.agoric/cache/b1-938304530ab413804ba64aa99a73cccb6f2068c285631463f5bd7e6e42dda81bc27fc81a6976ab7907d19d5d0e31ee5a1eaa05bc7234c7d102cc0a0f3a34ff60.json

bundle-source --to /home/connolly/projects/ag-statom/packages/inter-protocol/bundles /home/connolly/projects/ag-statom/packages/inter-protocol/src/price/fluxAggregatorContract.js fluxAggregatorKit
/home/connolly/projects/ag-statom/packages/inter-protocol/bundles bundle-fluxAggregatorKit.js valid: 171 files bundled at 2023-08-09T20:03:45.185Z
creating add-STARS-oracles-permit.json
creating add-STARS-oracles.js
You can now run a governance submission command like:
  agd tx gov submit-proposal swingset-core-eval add-STARS-oracles-permit.json add-STARS-oracles.js \
    --title="Enable <something>" --description="Evaluate add-STARS-oracles.js" --deposit=1000000ubld \
    --gas=auto --gas-adjustment=1.2
Remember to install bundles before submitting the proposal:
  agd tx swingset install-bundle @/home/connolly/.agoric/cache/b1-8fb229296073327ed26d2a1ac56eda2bdc70c99d68621895a88f6cc09bce2defa3bd0894e97950e5a0696388193279c8f6b9399809611f8fec3ef5aeed355ba5.json
  agd tx swingset install-bundle @/home/connolly/.agoric/cache/b1-1c8e93cc80b28b2cf6b1252e9b6edb0253a1f962889f8a255397b43984950a263dd9c9efd82aee5744b46e7bd57ff1c733030e9f4dc8da9b355b185a59687862.json

Done in 3.41s.

@dckc
Copy link
Collaborator Author

dckc commented Aug 9, 2023

ah... now I see the new bundles in the feat/statom1 branch (dad8bda , fef112e ).

Yup! That's a match.

@dckc dckc closed this as completed Aug 9, 2023
@dckc
Copy link
Collaborator Author

dckc commented Oct 12, 2023

things have changed enough that I'd like to confirm, again, that I can build the bundles

@dckc dckc reopened this Oct 12, 2023
@dckc dckc self-assigned this Oct 12, 2023
@dckc
Copy link
Collaborator Author

dckc commented Oct 13, 2023

Help? I'm unable to find the current yarn build:add-stATOM-proposal materials.

@0xpatrickdev
Copy link
Owner

@dckc they are in the latest commit on #22

6deb908

I can merge this in and take a "devnet" release cut

@dckc dckc added this to the launch critical milestone Oct 13, 2023
@dckc
Copy link
Collaborator Author

dckc commented Oct 13, 2023

all set on these now

@dckc dckc closed this as completed Oct 13, 2023
@dckc

This comment was marked as resolved.

Sign in to view
@dckc dckc mentioned this issue Feb 17, 2024
Open
@dckc

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
None yet
Projects
None yet
Milestone
launch critical
Development

No branches or pull requests
2 participants
@dckc @0xpatrickdev