Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault addCollateral proposal updates #11

Merged
merged 4 commits into from
Aug 18, 2023
Merged

vault addCollateral proposal updates #11

merged 4 commits into from
Aug 18, 2023

Conversation

0xpatrickdev
Copy link
Owner

@0xpatrickdev 0xpatrickdev commented Aug 8, 2023

Reproducable Bundles:

I am working off of this: Agoric/agoric-sdk@master...0xpatrickdev:agoric-sdk:pc/statom-vault-proposal

What was added

What is missing

Testing Status

I included ibc/toystatom in all the places that have ibc/toyatom in cosmic-swingset/Makefile, and this enables me to access test statom1 in the repl and other wallets.

I am (seemingly) able to submit oracles prices using the agops cli, but am getting a maxDebtFor called before a collateral quote was available error when opening an stATOM vault. This error occurs when storedCollateralQuote is undefined, so it seems I may be missing a step. Oracle prices must be sent from 2-3 addresses/operators, before the price registers. Once I included this in the flow, things are working as expected 🎉

image image

- use STATOM1 instead STATOM for testing
- limit powers in oracle proposal (economicCommitteeCreatorFacet, contractGovernor) see #5
- use testnet oracle address (+ my own) see #3
- bundles: use node v16.18.1, go 1.20.2, agoric-sdk master#9d4eaad see #9
@dckc
Copy link
Collaborator

dckc commented Aug 9, 2023

This is good progress. Several of the fixes look good.

If they were in their own PR(s), I would approve them, but I'm not sure what to do with this whole PR.

@dckc dckc mentioned this pull request Aug 9, 2023
Copy link
Collaborator

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I get it now. this addresses the issues in "what was added"

- guidance on how to provision + fund smart wallet on local
- explain how oracle prices must be sent from 2-3 addreses, depending the chain configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants