vault addCollateral proposal updates #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducable Bundles:
I am working off of this: Agoric/agoric-sdk@master...0xpatrickdev:agoric-sdk:pc/statom-vault-proposal
What was added
removed
economicCommitteeCreatorFacet
andcontractGovenor
from oracle permit: Agoric/agoric-sdk@b414246 (see minor: startGovernedUpgradable subsumes economicCommitteeCreatorFacet etc. #5)updated README instructions to suggest single proposal (see scripts need not go in separate proposals #6)
use
STATOM1
in proposal for now (see use correct denom for emerynet, mainnet #1, start with non-vbank ERTP asset? #10)update oracle operator addresses (decentral-devnet-config + pc address) (see Oracle operator addresses from mainnet should not be used for testing #3)
docs for oracle flow, and REPL validation
What is missing
restoreRef
forpriceAggregator
andscaledPriceAuthority
, but couldn't quite figure this out. I am not sure yet what needs to be changed so we have access torestoreRef
inadd-collateral-core.js
.Testing Status
I included
ibc/toystatom
in all the places that haveibc/toyatom
in cosmic-swingset/Makefile, and this enables me to access test statom1 in the repl and other wallets.I am (seemingly) able to submit oracles prices using the agops cli, but am getting aOracle prices must be sent from 2-3 addresses/operators, before the price registers. Once I included this in the flow, things are working as expected 🎉maxDebtFor called before a collateral quote was available
error when opening an stATOM vault. This error occurs whenstoredCollateralQuote
is undefined, so it seems I may be missing a step.