This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Support for JSON RPC simulateTransaction method #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
[skip ci]
[skip ci]
mikiw
changed the title
Support JSON RPC trace methods
Support for JSON RPC simulateTransaction method
Jun 2, 2023
[skip ci]
[skip ci]
[skip ci]
[skip ci]
I think that specification has exclusive conditions, I found that when I was digging out starknet codebase:
|
FabijanC
suggested changes
Jun 7, 2023
Co-authored-by: FabijanC <[email protected]>
[skip ci]
…arknet-devnet into json-rpc-methods
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
FabijanC
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
simulateTransaction
RPC,skip_validate
flag is supported butskip_execute
is not becausecreate_for_simulate
is missing that featureDevelopment related changes
get_predeployed_acc_execute_args()
method was moved torpc_utils.py
Checklist:
./scripts/format.sh
./scripts/lint.sh
./scripts/test.sh