Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

JSON-RPC API trace methods are missing #481

Closed
FabijanC opened this issue May 23, 2023 · 4 comments
Closed

JSON-RPC API trace methods are missing #481

FabijanC opened this issue May 23, 2023 · 4 comments
Labels
Duration: few days will take a few days Techno: python Python Type: bug Something isn't working

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented May 23, 2023

The three methods should be added: https://github.com/starkware-libs/starknet-specs/blob/v0.3.0-rc1/api/starknet_trace_api_openrpc.json

The link is for v0.3.0-rc1, but whichever is the current version at the time of development should be added (e.g. v0.3.0)

Note from Ariel:

...some of the methods there are still not implemented by existing nodes. For example, Pathfinder recently added simulate , but for nodes who don’t re-execute txs and rely on proofs, traceTransaction is problematic because it may require the replay of the entire block (this is currently unsupported there).

@ivpavici
Copy link
Contributor

For starknet.js, starknet_simulateTransaction is the most important one

@mikiw
Copy link
Contributor

mikiw commented May 30, 2023

so I started with starknet_simulateTransaction and yes v0.3.0 is there https://github.com/starkware-libs/starknet-specs/blob/v0.3.0/api/starknet_trace_api_openrpc.json

@ivpavici ivpavici moved this from 🆕 New to 🏗 In progress in starknet-devnet Jun 2, 2023
@mikiw
Copy link
Contributor

mikiw commented Jun 6, 2023

PR with starknet_simulateTransaction is here #492

starknet_traceTransaction and starknet_traceBlockTransactions will be added later

@mikiw
Copy link
Contributor

mikiw commented Jun 14, 2023

#492 PR with starknet_simulateTransaction was merged

@mikiw mikiw removed their assignment Jul 14, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in starknet-devnet Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duration: few days will take a few days Techno: python Python Type: bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants