This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC20BridgeSampler Curve #2483
ERC20BridgeSampler Curve #2483
Changes from 2 commits
7c9f3bc
626ff99
b5df33d
7d1577d
3088f99
78c07e6
9ad14ae
4323462
cb78ee3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess one of the things I get paranoid about is whether these endpoints are expressing the correct units. So maybe we can check that
samples[0] > 0 && samples[0] < toBaseUnitAmount(2, 6)