This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
ERC20BridgeSampler Curve #2483
Merged
ERC20BridgeSampler Curve #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
requested review from
abandeali1,
BMillman19,
dave4506,
fragosti and
hysz
as code owners
dekz
commented
Feb 13, 2020
| return samplerOperations.getKyberSellQuotes(makerToken, takerToken, takerFillAmounts); | ||
| batchedOperation = samplerOperations.getKyberSellQuotes(makerToken, takerToken, takerFillAmounts); | ||
| } else if (source === ERC20BridgeSource.Curve) { | ||
| // TODO(dekz) best way to pass this data around, in the world of multiple curves at once? |
There was a problem hiding this comment.
Not happy with this at the moment, there can be multiple Curve sources with the same tokens, like right now there is USDC/DAI and USDT/USDC/DAI. So it is not easy to tell the create_order which curveAddress should be used.
@dorothy-zbornak any thoughts on the right abstraction here? Pass it through DexSample? What will PLP look like as well?
dorothy-zbornak
approved these changes
Feb 14, 2020
| .sampleSellsFromCurve(curveAddress, daiTokenIdx, usdcTokenIdx, [toBaseUnitAmount(1)]) | ||
| .callAsync(); | ||
| expect(samples.length).to.be.bignumber.greaterThan(0); | ||
| expect(samples[0]).to.be.bignumber.greaterThan(0); |
There was a problem hiding this comment.
I guess one of the things I get paranoid about is whether these endpoints are expressing the correct units. So maybe we can check that samples[0] > 0 && samples[0] < toBaseUnitAmount(2, 6)
packages/asset-swapper/src/utils/market_operation_utils/create_order.ts
Outdated
Show resolved
Hide resolved
dekz
added a commit
that referenced
this pull request
Feb 15, 2020
* ERC20Sampler Curve * Use Bridge Sources for each Curve * Support multiple versions of the Curve contract * CHANGELOG and redeployed Curve (mainnet) * Fix Market ops utils test * Added Curve DAI USDC USDT TUSD * Bump sampler gas limit default * Decode the Curve in tests * Disable Curve in Buy tests
dekz
added a commit
that referenced
this pull request
Feb 15, 2020
* Curve ERC20Bridge * ERC20BridgeSampler Curve (#2483) * ERC20Sampler Curve * Use Bridge Sources for each Curve * Support multiple versions of the Curve contract * CHANGELOG and redeployed Curve (mainnet) * Fix Market ops utils test * Added Curve DAI USDC USDT TUSD * Bump sampler gas limit default * Decode the Curve in tests * Disable Curve in Buy tests * blockchainTests.fork.resets Curve and Sampler
dorothy-zbornak
pushed a commit
that referenced
this pull request
Feb 27, 2020
* Curve ERC20Bridge * ERC20BridgeSampler Curve (#2483) * ERC20Sampler Curve * Use Bridge Sources for each Curve * Support multiple versions of the Curve contract * CHANGELOG and redeployed Curve (mainnet) * Fix Market ops utils test * Added Curve DAI USDC USDT TUSD * Bump sampler gas limit default * Decode the Curve in tests * Disable Curve in Buy tests * blockchainTests.fork.resets Curve and Sampler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Samples the CurveBridge
#2480